Revert "Remount /sys/fs/cgroup as readonly always"#137
Merged
LK4D4 merged 1 commit intoopencontainers:masterfrom Jul 17, 2015
Merged
Revert "Remount /sys/fs/cgroup as readonly always"#137LK4D4 merged 1 commit intoopencontainers:masterfrom
LK4D4 merged 1 commit intoopencontainers:masterfrom
Conversation
This reverts commit 18de1a2. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
Contributor
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Jul 17, 2015
Revert "Remount /sys/fs/cgroup as readonly always"
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Adding cgroups path to the Spec.
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
The only discussion related to this is in [1,2], where the relationship between oomScoreAdj and disableOOMKiller is raised. But since 429f936 (Adding cgroups path to the Spec, 2015-09-02, opencontainers#137) resources has been tied to cgroups, and oomScoreAdj is not about cgroups. For example, we currently have (in config-linux.md): You can configure a container's cgroups via the resources field of the Linux configuration. I suggested we move the property from linux.resources.oomScoreAdj to linux.oomScoreAdj so config authors and runtimes don't have to worry about what cgroupsPath means if the only entry in resources is oomScoreAdj. Michael responded with [4]: If anything it should probably go on the process So that's what this commit does. I've gone with the four-space indents here to keep Pandoc happy (see 7795661 (runtime.md: Fix sub-bullet indentation, 2016-06-08, opencontainers#495), but have left the existing entries in this list unchanged to reduce churn. [1]: opencontainers/runtime-spec#236 [2]: opencontainers/runtime-spec#292 [3]: opencontainers/runtime-spec#137 [4]: opencontainers/runtime-spec#782 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 18de1a2.
It caused failures in docker test suite.
Signed-off-by: Mrunal Patel mrunalp@gmail.com