Skip to content

Revert "Remount /sys/fs/cgroup as readonly always"#137

Merged
LK4D4 merged 1 commit intoopencontainers:masterfrom
mrunalp:revert_cgroup_ro
Jul 17, 2015
Merged

Revert "Remount /sys/fs/cgroup as readonly always"#137
LK4D4 merged 1 commit intoopencontainers:masterfrom
mrunalp:revert_cgroup_ro

Conversation

@mrunalp
Copy link
Copy Markdown
Contributor

@mrunalp mrunalp commented Jul 17, 2015

This reverts commit 18de1a2.

It caused failures in docker test suite.

Signed-off-by: Mrunal Patel mrunalp@gmail.com

This reverts commit 18de1a2.
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jul 17, 2015

LGTM

LK4D4 added a commit that referenced this pull request Jul 17, 2015
Revert "Remount /sys/fs/cgroup as readonly always"
@LK4D4 LK4D4 merged commit 1eeb86f into opencontainers:master Jul 17, 2015
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
The only discussion related to this is in [1,2], where the
relationship between oomScoreAdj and disableOOMKiller is raised. But
since 429f936 (Adding cgroups path to the Spec, 2015-09-02, opencontainers#137)
resources has been tied to cgroups, and oomScoreAdj is not about
cgroups.  For example, we currently have (in config-linux.md):

  You can configure a container's cgroups via the resources field of
  the Linux configuration.

I suggested we move the property from linux.resources.oomScoreAdj to
linux.oomScoreAdj so config authors and runtimes don't have to worry
about what cgroupsPath means if the only entry in resources is
oomScoreAdj.  Michael responded with [4]:

  If anything it should probably go on the process

So that's what this commit does.

I've gone with the four-space indents here to keep Pandoc happy (see
7795661 (runtime.md: Fix sub-bullet indentation, 2016-06-08, opencontainers#495),
but have left the existing entries in this list unchanged to reduce
churn.

[1]: opencontainers/runtime-spec#236
[2]: opencontainers/runtime-spec#292
[3]: opencontainers/runtime-spec#137
[4]: opencontainers/runtime-spec#782 (comment)

Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants