conversion: add platform conversions#711
Merged
cyphar merged 1 commit intoopencontainers:masterfrom Mar 11, 2018
cyphar:conversion-platform-annotations
Merged
conversion: add platform conversions#711cyphar merged 1 commit intoopencontainers:masterfrom cyphar:conversion-platform-annotations
cyphar merged 1 commit intoopencontainers:masterfrom
cyphar:conversion-platform-annotations
Conversation
In b6d5a8c ("Change platform ref from runtime-spec"), the conversion to runtime-spec for the "os" and "architecture" fields was removed (as the fields had also been removed in runtime-spec). Re-add the conversion as an annotation field rather than a verbatim field. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Member
Author
|
/ping @opencontainers/image-spec-maintainers -- this really should've gone into |
Contributor
|
Nothing controversial here, but can these be |
Contributor
|
I don't think they can be a MUST. |
Member
Author
|
Are we not allowed to MUST new features in new releases? Also, this document's "MUST" language refers to the "default generated runtime configuration" which in principle could be modified to remove these annotations -- so a runtime that does the wrong thing here isn't non-compliant. |
Member
Author
Member
Author
jonboulle
approved these changes
Feb 8, 2018
Contributor
|
LGTM @cyphar Not sure if these can be a MUST, still. |
cyphar
added a commit
that referenced
this pull request
Mar 11, 2018
conversion: add platform conversions LGTMs: @jonboulle @stevvooe Closes #711
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In b6d5a8c ("Change platform ref from runtime-spec"), the
conversion to runtime-spec for the "os" and "architecture" fields was
removed (as the fields had also been removed in runtime-spec). Re-add
the conversion as an annotation field rather than a verbatim field.
[Obviously this can't go into
1.0.0due to the time window, but we can put it in1.0.1].Signed-off-by: Aleksa Sarai asarai@suse.de