manifest.md: use base layer instead of base image#463
Merged
vbatts merged 1 commit intoopencontainers:masterfrom Nov 30, 2016
Merged
manifest.md: use base layer instead of base image#463vbatts merged 1 commit intoopencontainers:masterfrom
base layer instead of base image#463vbatts merged 1 commit intoopencontainers:masterfrom
Conversation
We doesn't define a `base image`, use `base layer` is correct. This issue first being addressed in pr opencontainers#312, and then being addressed in pr opencontainers#318, and then in pr opencontainers#407, but landing opencontainers#407 has a long way to go. We could addressed this first to avoid confusing. Signed-off-by: Lei Jitang <leijitang@huawei.com>
Contributor
|
6bc08bc looks good to me.
|
Contributor
|
And note that this is exactly the same patch as #312. That PR was |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We doesn't define a
base image, usebase layeriscorrect. This issue first being addressed in pr #312,
and then being addressed in pr #318, and then in pr #407,
but landing #407 has a long way to go. We could address
this first to avoid confusing.
Signed-off-by: Lei Jitang leijitang@huawei.com