Json schema for image manifest and manifest list by vbatts · Pull Request #18 · opencontainers/image-spec

vbatts · 2016-04-12T18:45:14Z

related to #7

testing against https://gist.github.com/vbatts/b3e4fc231fbc92a9cbc28b9184f0b2d2

From opencontainers/runtime-spec@cdcabde Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Here is a validating schema for the Image Manifest https://github.com/opencontainers/image-spec/blob/master/manifest.md#image-manifest Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

https://github.com/opencontainers/image-spec/blob/master/manifest.md#manifest-list Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

wking · 2016-04-12T19:16:46Z

On Tue, Apr 12, 2016 at 11:45:14AM -0700, Vincent Batts wrote:

schema: copy common from runtime
…
A schema/defs.json (160)

While it's nice to have local copies of this sort of thing for offline
use, it's more DRY and probably easier to maintain to just $ref the
runtime-spec defs.json. Stuff like:

"$ref": "https://raw.githubusercontent.com/opencontainers/runtime-spec/v0.5.0/schema/defs.json#/definitions/mapStringString"

should work fine, although it's probably nicer if we just host these
under opencontainers.org/schema/… or some such.

vbatts · 2016-04-12T19:26:33Z

I mulled on that too. This is a first step.

philips · 2016-04-14T02:37:07Z

LGTM, can you file issues for steps after this?

stevvooe · 2016-04-15T20:07:06Z

schema/defs-image.json

+      "type": "string",
+      "pattern": "^[a-z0-9]+:[a-fA-F0-9]+$"
+    },
+    "blobObject": {


This is actually called a "Descriptor".

where is that defined?

On Fri, Apr 15, 2016 at 1:07 PM Stephen Day notifications@github.com
wrote:

In schema/defs-image.json
#18 (comment)
:

@@ -0,0 +1,99 @@
+{

"description": "Definitions particular to OpenContainer Image Specification",

"definitions": {

"mediaType": {

"id": "https://opencontainers.org/schema/image/mediaType",

"type": "string",

"pattern": "^[a-z]+/[0-9a-zA-Z.+]+$"

},

"digest": {

"description": "the cryptographic checksum digest of the object, in the pattern '<hash>:<hexadecimal digest>'",

"type": "string",

"pattern": "^[a-z0-9]+:[a-fA-F0-9]+$"

},

"blobObject": {

This is actually called a "Descriptor".

—
You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
https://github.com/opencontainers/image-spec/pull/18/files/64b5003c9985ba8714201f1ecc01460770ab5828#r59933563

This is what we have called it from the start. The godoc is here. I am not sure how it never made into this specification.

Other types with further fields, such as the manifest descriptor, are extensions to the descriptor type.

ah fine. A name of a struct. Feel free to open a PR to include this in the
spec. I can update it here.

On Fri, Apr 15, 2016 at 1:27 PM Stephen Day notifications@github.com
wrote:

In schema/defs-image.json
#18 (comment)
:

@@ -0,0 +1,99 @@
+{

"description": "Definitions particular to OpenContainer Image Specification",

"definitions": {

"mediaType": {

"id": "https://opencontainers.org/schema/image/mediaType",

"type": "string",

"pattern": "^[a-z]+/[0-9a-zA-Z.+]+$"

},

"digest": {

"description": "the cryptographic checksum digest of the object, in the pattern '<hash>:<hexadecimal digest>'",

"type": "string",

"pattern": "^[a-z0-9]+:[a-fA-F0-9]+$"

},

"blobObject": {

This is what we have called it from the start. The godoc is here
https://godoc.org/github.com/docker/distribution#Descriptor. I am not
sure how it never made into this specification.

Other types with further fields, such as the manifest descriptor, are
extensions to the descriptor type.

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/image-spec/pull/18/files/64b5003c9985ba8714201f1ecc01460770ab5828#r59936055

Yea, I'll do that. Just reviewing old notifications.

vbatts · 2016-04-15T20:48:48Z

haha. I see I added the definitions for the manifest list, but didn't git add the actual schema for the manifest list. smh

I managed to forget adding the file in opencontainers#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Previously we didn't define what a media type was and the old regular expression (from 818a56a, schema: image manifest, 2016-04-12, opencontainers#18) was stricter than the RFC. The RFC rules are in [1], and the JSON Schema regexp syntax is in [2]. In the new pattern, * [A-Za-z0-9] is restricted-name-first (ALPHA / DIGIT), with ALPHA and DIGIT defined in RFC 5234 [3]. * [A-Za-z0-9!#$&-^_.+] is restricted-name-chars. [1]: https://tools.ietf.org/html/rfc6838#section-4.2 [2]: https://tools.ietf.org/html/draft-wright-json-schema-validation-00#section-3.3 [3]: https://tools.ietf.org/html/rfc5234#appendix-B.1 Signed-off-by: W. Trevor King <wking@tremily.us>

I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Signed-off-by: Sajay Antony <sajaya@microsoft.com>

I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

vbatts added 3 commits April 12, 2016 13:42

schema: copy common from runtime

363d55a

From opencontainers/runtime-spec@cdcabde Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

schema: image manifest

818a56a

Here is a validating schema for the Image Manifest https://github.com/opencontainers/image-spec/blob/master/manifest.md#image-manifest Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

schema: image manifest list

64b5003

https://github.com/opencontainers/image-spec/blob/master/manifest.md#manifest-list Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

philips added component/manifest spec kind/enhancement area/compliance labels Apr 14, 2016

philips added this to the v0.1.0 milestone Apr 14, 2016

vbatts merged commit 19e812c into opencontainers:master Apr 14, 2016

vbatts deleted the json_schema branch April 14, 2016 14:54

vbatts mentioned this pull request Apr 14, 2016

JSON schema all the things #7

Closed

stevvooe reviewed Apr 15, 2016
View reviewed changes

vbatts added a commit to vbatts/oci-image-spec that referenced this pull request Apr 15, 2016

schema: actually add the schema file

a563210

I managed to forget adding the file in opencontainers#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

vbatts mentioned this pull request Apr 15, 2016

schema: actually add the schema file #32

Merged

vbatts added a commit to vbatts/oci-image-spec that referenced this pull request Apr 15, 2016

schema: actually add the schema file

0947a33

I managed to forget adding the file in opencontainers#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

wking mentioned this pull request Apr 20, 2016

Create golden standards to test against json schema #34

Closed

dattgoswami9lk5g added a commit to dattgoswami9lk5g/bremlinr that referenced this pull request Jun 6, 2022

schema: actually add the schema file

803e821

I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

7c00d pushed a commit to 7c00d/J1nHyeockKim that referenced this pull request Jun 6, 2022

schema: actually add the schema file

bd62507

I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

7c00d added a commit to 7c00d/J1nHyeockKim that referenced this pull request Jun 6, 2022

schema: actually add the schema file

beba8db

I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

laventuraw added a commit to laventuraw/Kihara-tony0 that referenced this pull request Jun 6, 2022

schema: actually add the schema file

de0c32a

I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

sudo-bmitch pushed a commit to sudo-bmitch/image-spec that referenced this pull request Aug 24, 2022

Update blobs and refers to descriptors (opencontainers#18)

ba413fa

Signed-off-by: Sajay Antony <sajaya@microsoft.com>

tomalopbsr0tt added a commit to tomalopbsr0tt/fabiojosej that referenced this pull request Oct 6, 2022

schema: actually add the schema file

b0679f9

I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Json schema for image manifest and manifest list#18

Json schema for image manifest and manifest list#18
vbatts merged 3 commits intoopencontainers:masterfrom
vbatts:json_schema

vbatts commented Apr 12, 2016

Uh oh!

wking commented Apr 12, 2016

Uh oh!

vbatts commented Apr 12, 2016

Uh oh!

philips commented Apr 14, 2016

Uh oh!

stevvooe Apr 15, 2016

Uh oh!

vbatts Apr 15, 2016

Uh oh!

stevvooe Apr 15, 2016

Uh oh!

vbatts Apr 15, 2016

Uh oh!

stevvooe Apr 15, 2016

Uh oh!

vbatts commented Apr 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vbatts commented Apr 12, 2016

Uh oh!

wking commented Apr 12, 2016

Uh oh!

vbatts commented Apr 12, 2016

Uh oh!

philips commented Apr 14, 2016

Uh oh!

stevvooe Apr 15, 2016

Choose a reason for hiding this comment

Uh oh!

vbatts Apr 15, 2016

Choose a reason for hiding this comment

Uh oh!

stevvooe Apr 15, 2016

Choose a reason for hiding this comment

Uh oh!

vbatts Apr 15, 2016

Choose a reason for hiding this comment

Uh oh!

stevvooe Apr 15, 2016

Choose a reason for hiding this comment

Uh oh!

vbatts commented Apr 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants