manifest: use descriptor doc as canonical source#143
Merged
vbatts merged 1 commit intoopencontainers:masterfrom Jun 16, 2016
Merged
manifest: use descriptor doc as canonical source#143vbatts merged 1 commit intoopencontainers:masterfrom
vbatts merged 1 commit intoopencontainers:masterfrom
Conversation
Right now manifest is relying on the external Docker docs to explain the digest format. Instead use the OCI Descriptor docs. Signed-off-by: Brandon Philips <brandon.philips@coreos.com>
Member
|
+1 |
Contributor
|
LGTM |
Contributor
Author
|
LGTM |
1 similar comment
Member
|
LGTM |
wking
added a commit
to wking/image-spec
that referenced
this pull request
Jul 2, 2016
1149fac (manifest: use descriptor doc as canonical source, 2016-06-15, opencontainers#143) was a step in this direction. But we can DRY things up a bit more by punting those three properties entirely and just saying "it's a descriptor", and then listing extensions, if any. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/image-spec
that referenced
this pull request
Jul 2, 2016
1149fac (manifest: use descriptor doc as canonical source, 2016-06-15, opencontainers#143) was a step in this direction. But we can DRY things up a bit more by punting those three properties entirely and just saying "it's a descriptor", and then listing extensions, if any. Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now manifest is relying on the external Docker docs to explain the
digest format. Instead use the OCI Descriptor docs.
Signed-off-by: Brandon Philips brandon.philips@coreos.com