image-layout: clarification#136
Merged
vbatts merged 2 commits intoopencontainers:masterfrom Jun 14, 2016
Merged
Conversation
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
image-layout.md
Outdated
| ./refs | ||
| ./refs/v1.0 | ||
| ./refs/v1.1 | ||
| ./refs/another-ref |
Member
There was a problem hiding this comment.
Good point to have a generic reference. Perhaps it could be something like ./refs/stable-release?
Member
Author
There was a problem hiding this comment.
I can name it as you wish
Contributor
|
besides the feedback from @vbatts this LGTM |
Member
|
one nit, but LGTM |
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
| ``` | ||
|
|
||
| Object names in the refs and blobs MUST NOT include characters outside of the set of "A" to "Z", "a" to "z", the hyphen `-`, the dot `.`, and the underscore `_`. | ||
| Object names in the `refs` and `blobs` MUST NOT include characters outside of the set of "A" to "Z", "a" to "z", the hyphen `-`, the dot `.`, and the underscore `_`. |
Contributor
There was a problem hiding this comment.
A few comments on this line:
- We should include the digits
0through9. - Aren't the blob filenames already completely specified?
{algo}-{hex-digest}with a defined list of algorithms cannot exceed this set unless we explicitly assign an algorithm an odd tag.
This was referenced Oct 28, 2016
wking
added a commit
to wking/image-spec
that referenced
this pull request
Dec 20, 2016
This ref -> descriptor example caption gained "blobs the manifest references" wording with 2f24791 (image-layout.md: explain blobs can be anything, 2016-06-14, opencontainers#136), but I don't see a direct relationship between descriptors and those deeper-ancestor blobs. I think we either want to revert the changes 2f24791 made to this line or drop the line. In this commit I drop the line, because the other points covered by the sentence are already covered in other descriptor docs. And it's pretty clear just from the example command and output that this is showing the content of a ref pointing at a manifest list. Signed-off-by: W. Trevor King <wking@tremily.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #132
Fix #134
/cc @vbatts @philips