As pointed out by @andaaron in opencontainers#425, the regular expression
proposed there was bogus. It was actually wrong in two different ways.
Mea culpa, my apologies.

This fixes it. I wrote a few test cases to check: https://go.dev/play/p/4_iYH4Hao1-

```go
package main

import (
	"regexp"
	"testing"
)

func TestRepoPattern(t *testing.T) {
	r := regexp.MustCompile(`^[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*(/[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*)*$`)
	for _, test := range []struct {
		s    string
		want bool
	}{
		{"foo", true},
		{"foo/bar", true},
		{"foo/bar__baz", true},
		{"foo/bar___baz", false},
		{"/foo", false},
		{"foo//bar", false},
		{"foo-------b__x.com", true},
		{"foo-------b__x.com/p----x", true},
		{"foo-", false},
		{"-foo", false},
		{"foo/-bar", false},
		{"foo/bar-", false},
		{"foo-bar", true},
		{"foo----_bar", false},
		{"foo----bar_/x", false},
	} {
		if got, want := r.MatchString(test.s), test.want; got != want {
			t.Errorf("mismatch on %q; got %v want %v", test.s, got, want)
		}
	}
}
```

Ideally something like the above would be committed for CI testing
but perhaps that's a stage too far.

Signed-off-by: Roger Peppe <rogpeppe@gmail.com>

As pointed out by @andaaron in #425, the regular expression
proposed there was bogus. It was actually wrong in two different ways.
Mea culpa, my apologies.

This fixes it. I wrote a few test cases to check: https://go.dev/play/p/4_iYH4Hao1-

```go
package main

import (
	"regexp"
	"testing"
)

func TestRepoPattern(t *testing.T) {
	r := regexp.MustCompile(`^[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*(/[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*)*$`)
	for _, test := range []struct {
		s    string
		want bool
	}{
		{"foo", true},
		{"foo/bar", true},
		{"foo/bar__baz", true},
		{"foo/bar___baz", false},
		{"/foo", false},
		{"foo//bar", false},
		{"foo-------b__x.com", true},
		{"foo-------b__x.com/p----x", true},
		{"foo-", false},
		{"-foo", false},
		{"foo/-bar", false},
		{"foo/bar-", false},
		{"foo-bar", true},
		{"foo----_bar", false},
		{"foo----bar_/x", false},
	} {
		if got, want := r.MatchString(test.s), test.want; got != want {
			t.Errorf("mismatch on %q; got %v want %v", test.s, got, want)
		}
	}
}
```

Ideally something like the above would be committed for CI testing
but perhaps that's a stage too far.

Signed-off-by: Roger Peppe <rogpeppe@gmail.com>

This change makes the separators consistent with the implementation in the Docker distribution
[here](https://github.com/distribution/distribution/blob/97b1d649c4938d0f608d96454d6a8326b1f96acd/reference/regexp.go#L53).

Relevant parts from that code:

```
separator = `(?:[._]|__|[-]+)`
pathComponent = alphanumeric + anyTimes(separator+alphanumeric)
remoteName = pathComponent + anyTimes(`/`+pathComponent)
namePat    = optional(domainAndPort+`/`) + remoteName
```

Signed-off-by: Roger Peppe <rogpeppe@gmail.com>

As pointed out by @andaaron in opencontainers#425, the regular expression
proposed there was bogus. It was actually wrong in two different ways.
Mea culpa, my apologies.

This fixes it. I wrote a few test cases to check: https://go.dev/play/p/4_iYH4Hao1-

```go
package main

import (
	"regexp"
	"testing"
)

func TestRepoPattern(t *testing.T) {
	r := regexp.MustCompile(`^[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*(/[a-z0-9]+((\.|_|__|-+)[a-z0-9]+)*)*$`)
	for _, test := range []struct {
		s    string
		want bool
	}{
		{"foo", true},
		{"foo/bar", true},
		{"foo/bar__baz", true},
		{"foo/bar___baz", false},
		{"/foo", false},
		{"foo//bar", false},
		{"foo-------b__x.com", true},
		{"foo-------b__x.com/p----x", true},
		{"foo-", false},
		{"-foo", false},
		{"foo/-bar", false},
		{"foo/bar-", false},
		{"foo-bar", true},
		{"foo----_bar", false},
		{"foo----bar_/x", false},
	} {
		if got, want := r.MatchString(test.s), test.want; got != want {
			t.Errorf("mismatch on %q; got %v want %v", test.s, got, want)
		}
	}
}
```

Ideally something like the above would be committed for CI testing
but perhaps that's a stage too far.

Signed-off-by: Roger Peppe <rogpeppe@gmail.com>