Skip to content

Allow 405 Method Not Allowed for DELETE requests in teardowns#185

Merged
jdolitsky merged 1 commit intoopencontainers:masterfrom
markphelps:allow-405-on-teardowns
Oct 7, 2020
Merged

Allow 405 Method Not Allowed for DELETE requests in teardowns#185
jdolitsky merged 1 commit intoopencontainers:masterfrom
markphelps:allow-405-on-teardowns

Conversation

@markphelps
Copy link
Copy Markdown

Fixes: #179

Allows 405 Method Not Allowed HTTP Response Status in teardown methods in conformance tests

Signed-off-by: Mark Phelps <mark.aaron.phelps@gmail.com>
Copy link
Copy Markdown
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markphelps
Copy link
Copy Markdown
Author

Thanks @jdolitsky, is there anything blocking this from being merged?

@jdolitsky
Copy link
Copy Markdown
Contributor

Hi, just waiting on another LGTM cc @opencontainers/distribution-spec-maintainers

@markphelps
Copy link
Copy Markdown
Author

@jdolitsky it doesnt seem that team @opencontainers/distribution-spec-maintainers exists anymore, is there perhaps someone individually that can take a look? thanks!

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky jdolitsky merged commit e6be018 into opencontainers:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conformance: Allow 405 Status for all tear down / deletes

3 participants