Skip to content

Conformance: Allow 405 Status for all tear down / deletes #179

@markphelps

Description

@markphelps

Much like what was implemented in https://github.com/opencontainers/distribution-spec/pull/151/files#diff-fddb7a1636af89303c8fcf32651486a9R260 for 02_push_test.go, it would be great if you could allow this for all the other tests.

For example, our registry does not currently support deletion through the CLI, so all of the other tests are failing in the tear down step with errors such as:

 OCI Distribution Conformance Tests
/go/src/github.com/opencontainers/distribution-spec/conformance/00_conformance_suite_test.go:12
  Pull
  /go/src/github.com/opencontainers/distribution-spec/conformance/01_pull_test.go:14
    Teardown
    /go/src/github.com/opencontainers/distribution-spec/conformance/01_pull_test.go:154
      Delete manifest created in setup [It]
      /go/src/github.com/opencontainers/distribution-spec/conformance/01_pull_test.go:191

      Expected
          <int>: 405
      to be <
          <int>: 300

      /go/src/github.com/opencontainers/distribution-spec/conformance/01_pull_test.go:197

It seems like HTTP 405 s should be allowed in the teardown of the following tests:

  1. 01_pull_test.go
  2. 03_discovery_test.go
  3. 04_management_test.go

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions