Fix max lane per port#1112
Merged
lguohan merged 2 commits intoopencomputeproject:masterfrom Jul 3, 2020
Merged
Conversation
added 2 commits
July 3, 2020 14:14
It assumes there are only 4 lanes per port which is not correct because there are 8 lanes per port on MSN4700 for 400G ports Signed-off-by: Stephen Sun <stephens@mellanox.com>
…t in function sai_thrift_get_port_attribute Signed-off-by: Stephen Sun <stephens@mellanox.com>
itaibaz
approved these changes
Jul 3, 2020
Contributor
Author
|
Hi @lguohan |
lguohan
pushed a commit
that referenced
this pull request
Jul 3, 2020
* Extend the maximum lanes per port from 4 to 8 It assumes there are only 4 lanes per port which is not correct because there are 8 lanes per port on MSN4700 for 400G ports * Remove unnecessary assignment statement to thrift_attr_list.attr_count in function sai_thrift_get_port_attribute Signed-off-by: Stephen Sun <stephens@mellanox.com>
lguohan
pushed a commit
that referenced
this pull request
Jul 3, 2020
* Extend the maximum lanes per port from 4 to 8 It assumes there are only 4 lanes per port which is not correct because there are 8 lanes per port on MSN4700 for 400G ports * Remove unnecessary assignment statement to thrift_attr_list.attr_count in function sai_thrift_get_port_attribute Signed-off-by: Stephen Sun <stephens@mellanox.com>
Collaborator
|
done |
Contributor
Author
|
Thank you! |
Contributor
Author
|
Hi @lguohan, Can we cherry-pick the above commit into v1.5 and re-tag v1.5.2? After that, we can update sairedis and bring this PR into SONiC 201911. |
lguohan
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Extend the maximum lanes per port from 4 to 8 It assumes there are only 4 lanes per port which is not correct because there are 8 lanes per port on MSN4700 for 400G ports * Remove unnecessary assignment statement to thrift_attr_list.attr_count in function sai_thrift_get_port_attribute Signed-off-by: Stephen Sun <stephens@mellanox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It assumes there are only 4 lanes per port, which is not correct because
there are 8 lanes per port on MSN4700 for 400G ports
Unnecessary assignment to thrift_attr_list.attr_count in function sai_thrift_get_port_attribute has been removed as well.
Signed-off-by: Stephen Sun stephens@mellanox.com