fix(ci): debounce canonical main runner admission#95681
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 22, 2026, 4:10 AM ET / 08:10 UTC. Summary PR surface: Tests +16, Docs +13, Config +22. Total +51 across 3 files. Reproducibility: not applicable. this is a maintainer CI workflow change rather than a user bug report. Source inspection and PR CI logs prove the PR path takes the no-op admission branch; the real canonical-main sleep path is only observable on Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the hosted debounce only after exact-head CI is acceptable, then keep the documented Do we have a high-confidence way to reproduce the issue? Not applicable: this is a maintainer CI workflow change rather than a user bug report. Source inspection and PR CI logs prove the PR path takes the no-op admission branch; the real canonical-main sleep path is only observable on Is this the best way to solve the issue? Yes, this is a narrow workflow-layer solution: it gates the two root CI jobs that can register Blacksmith work, while downstream jobs already depend on AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against d3f7f7d1fc91. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +16, Docs +13, Config +22. Total +51 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Compacts canonical pull request CI to 18 bounded Node jobs, preserves isolated subprocess execution, and delays canonical main runner admission to smooth GitHub runner-registration bursts. Verification: focused CI planner/workflow tests passed; fresh autoreview clean. Hosted CI had two pre-existing runtime-config failures on the current main baseline; merged with explicit maintainer override.
Summary
Verification
node scripts/run-vitest.mjs test/scripts/ci-workflow-guards.test.tsgit diff --checkThis keeps PR and manual CI immediate; only canonical main pushes sleep.