fix(channel): harden local setup trust#92175
Conversation
|
Codex review: passed. Reviewed June 11, 2026, 9:44 AM ET / 13:44 UTC. Summary PR surface: Source +190, Tests +892, Other +324. Total +1406 across 13 files. Reproducibility: yes. The source PR provides a concrete clean-main Docker/package path where an explicitly trusted Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land one canonical local-plugin trust rule across catalog selection and scoped loader imports, preserving explicit trusted setup and origin-aware safe fallback while clearly accepting the fail-closed upgrade behavior. Do we have a high-confidence way to reproduce the issue? Yes. The source PR provides a concrete clean-main Docker/package path where an explicitly trusted Is this the best way to solve the issue? Yes. The patch uses the existing manifest-owner policy at both catalog and loader owner boundaries, threads the existing load-path configuration into discovery, and narrows fallback exclusion to the rejected origin/plugin pair instead of adding a competing trust mechanism. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 047785eb30c0. Label changesLabel justifications:
Evidence reviewedPR surface: Source +190, Tests +892, Other +324. Total +1406 across 13 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
🦞✅ Source: What merged:
Automerge notes:
The automerge loop is complete. Automerge progress:
|
Thread plugins.load.paths through channel trusted-catalog discovery, make trusted fallback origin-aware, and block untrusted non-bundled channel plugins from scoped setup-only imports across workspace, config, and global origins. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bf86d9f to
eabee04
Compare
Summary: - The PR extends channel setup trust enforcement and trusted catalog fallback from workspace-origin plugins to ... nfigured load paths into catalog discovery, and adds focused regression plus Docker/package proof coverage. - PR surface: Source +190, Tests +892, Other +324. Total +1406 across 13 files. - Reproducibility: yes. The source PR provides a concrete clean-main Docker/package path where an explicitly t ... ns unresolved, while the patched package resolves it and still blocks untrusted module and setup execution. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(channel): stabilize trusted catalog dts typing - PR branch already contained follow-up commit before automerge: fix(channel): repair trusted catalog exclusions typing - PR branch already contained follow-up commit before automerge: test(channel): cover local channel plugin trust - PR branch already contained follow-up commit before automerge: chore(deps): refresh plugin shrinkwraps - PR branch already contained follow-up commit before automerge: test(channel): route trust regression in command shard - PR branch already contained follow-up commit before automerge: test(channel): remove e2e-named trust regression Validation: - ClawSweeper review passed for head eabee04. - Required merge gates passed before the squash merge. Prepared head SHA: eabee04 Review: openclaw#92175 (comment) Co-authored-by: Mason Huang <masonxhuang@tencent.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: hxy91819 Co-authored-by: hxy91819 <8814856+hxy91819@users.noreply.github.com>
Makes #89456 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
Known failing checks:
ClawSweeper 🐠 replacement reef notes:
Co-author credit kept:
fish notes: reasoning high; reviewed against bf86d9f.