perf(qqbot): narrow tool discovery cold load#90780
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 2:50 AM ET / 06:50 UTC. Summary PR surface: Source +15, Tests +2. Total +17 across 5 files. Reproducibility: not applicable. as a bug reproduction. The PR's performance claim has before/after profiling evidence, and the source path that previously loaded the broad QQBot barrel is clear from current main and the PR diff. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow-sidecar implementation after current-head validation confirms the packaged QQBot sidecars and bundled-entry guard remain green. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction. The PR's performance claim has before/after profiling evidence, and the source path that previously loaded the broad QQBot barrel is clear from current main and the PR diff. Is this the best way to solve the issue? Yes, this is the best fit among the inspected options. A narrow top-level sidecar matches the extension boundary guidance and avoids the broad AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 97d68b69027f. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +15, Tests +2. Total +17 across 5 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
147a66b to
01c2356
Compare
This comment has been minimized.
This comment has been minimized.
01c2356 to
87b981f
Compare
3df135d to
f175f07
Compare
* perf: narrow qqbot tool discovery load * fix(qqbot): load bridge entries through sidecars
* perf: narrow qqbot tool discovery load * fix(qqbot): load bridge entries through sidecars
Profile Evidence
.artifacts/tui-local-cpu/full-surface-1780700761191/openclaw-tui-99042-2026-06-05T23-06-02-328Z.cpuprofile.artifacts/tui-local-cpu/full-surface-narrow-tools-1780700900305/openclaw-tui-17302-2026-06-05T23-08-29-149Z.cpuprofileCPU profile summaries showed the first turn is cold module loading, not provider latency: top samples were
dist/jiti.cjs, Babel transforms,package_json_reader,fsstat/open/read, and ESM compile. The mocked local Responses server returned in ~20ms; the delay happened before the request was sent.Summary
tool-discoveryregistration through the narrow tool registration module instead of the broad publicapi.tsbarrel.qqbot_channel_apiexecutes, so tool registration does not import messaging sender/runtime code.Verification
node scripts/run-vitest.mjs extensions/qqbot/src/bridge/commands/framework-registration.test.ts extensions/qqbot/src/bridge/tools/remind.test.ts extensions/qqbot/src/engine/tools/remind-logic.test.ts src/plugin-sdk/channel-entry-contract.test.tspnpm buildgit diff --checkpnpm openclaw tui --localwith an isolated config and mocked local Responses endpoint before and after the patch.