refactor: make OpenAI Codex legacy doctor-only#88605
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12c6c588ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (commandArgs[0] !== "run" || isWindowsRemoteTarget(commandArgs)) { | ||
| return commandArgs; |
There was a problem hiding this comment.
Mark Windows changed gates as remote children
When a changed gate is launched through Crabbox on a Windows target (for example run --target windows -- corepack pnpm check:changed), this early return leaves the remote command without OPENCLAW_CHECK_CHANGED_REMOTE_CHILD=1. Since check-changed.mjs now delegates by default whenever that marker/CI is absent, the command executed on the Windows machine will start another Crabbox/Testbox run instead of running the gate locally; the updated Windows test confirms the args are left completely unmarked.
Useful? React with 👍 / 👎.
Summary
openai-codexandopenai-codex-responsesare no longer accepted runtime identifiers.openclaw doctor --fix, including shadowedmodels.providers.openai-codexremoval when canonicalopenaiconfig already exists.pnpm check:changeddelegate through Crabbox/Testbox by default, snapshots staged paths for remote proof, handles empty staged sets, and marks remote changed-gate children to prevent recursive delegation.Verification
git diff --checknode scripts/run-vitest.mjs test/scripts/crabbox-wrapper.test.ts -- --reporter=dot(115 tests passed)cbx_fb37d03733a8/amber-crab, runrun_7fd2c0d2fa07,corepack pnpm test test/scripts/crabbox-wrapper.test.ts test/scripts/changed-lanes.test.ts -- --reporter=verbose(170 tests passed)cbx_ec3546011dbe/tidal-prawn, runrun_f9f39e7737ea, plain remotecorepack pnpm check:changed; wrapper executed it asenv OPENCLAW_CHECK_CHANGED_REMOTE_CHILD=1 OPENCLAW_CHANGED_LANES_RAW_SYNC=1 corepack pnpm check:changedand the gate passed.agents/skills/autoreview/scripts/autoreview --mode localclean, no accepted/actionable findingsReal behavior proof
Behavior addressed: OpenAI Codex identifiers are retired from runtime configuration and
check:changedno longer runs broad gates locally or recursively delegates from remote Crabbox runs.Real environment tested: AWS Crabbox Linux (
provider=aws) with fresh remote syncs for focused tests and broad changed-gate proof.Exact steps or command run after this patch:
node scripts/crabbox-wrapper.mjs run --provider aws --idle-timeout 90m --ttl 240m --timing-json -- corepack pnpm check:changed.Evidence after fix: Run
run_f9f39e7737eaon leasecbx_ec3546011dbeprinted the remote command withOPENCLAW_CHECK_CHANGED_REMOTE_CHILD=1andOPENCLAW_CHANGED_LANES_RAW_SYNC=1, then completed all changed lanes successfully.Observed result after fix: Legacy OpenAI Codex config now migrates through doctor-only code paths, and changed gates run on Crabbox with remote-child protection instead of recursing or falling back to local broad checks.
What was not tested: Windows-native changed-gate execution in this final pass; Windows still skips the POSIX changed-gate bootstrap as before.