refactor(agents): type media completion delivery misses#88250
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: refactor(agents): type media completion delivery misses This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
mcaxtr
pushed a commit
that referenced
this pull request
May 30, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 31, 2026
SYU8384
pushed a commit
to SYU8384/openclaw
that referenced
this pull request
Jun 3, 2026
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Behavior addressed: media generation completion fallback no longer depends on matching subagent delivery error prose.
Real environment tested: local macOS checkout plus delegated Blacksmith Testbox changed-check run.
Exact steps or command run after this patch:
pnpm test src/agents/subagent-announce-delivery.test.ts src/agents/tools/media-generate-background-shared.test.ts src/agents/tools/image-generate-background.test.ts src/agents/tools/music-generate-background.test.ts src/agents/tools/video-generate-background.test.ts src/agents/image-generation-task-status.test.ts;pnpm check:changed;.agents/skills/autoreview/scripts/autoreview --mode local;.agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main.Evidence after fix: focused Vitest passed 6 files / 133 tests; Testbox
tbx_01ksvpvnns2sxbj8gjs0xx7n1fexited 0; both autoreview runs reported no accepted/actionable findings.Observed result after fix: delivery fallback eligibility comes from
SubagentAnnounceDeliveryFailureReason, with success paths and non-fallback failures unchanged.What was not tested: live media provider generation round-trip.