Fix iMessage group media delivery#86720
Conversation
|
Testing note for #83365: On this Lobster machine, the reproduced failure was specific to group media delivery through the existing rich/file path:
This PR therefore changes OpenClaw's explicit-chat, media-only iMessage send path to use |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: Fix iMessage group media delivery This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
|
Live validation after this PR was built locally from commit
This validates the PR's media-only iMessage delivery path for both an explicit group |
|
@clawsweeper re-review Fresh proof is now on the PR: Lobster built commit |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Maintainer verification before merge:
No changelog entry added per maintainer direction. |
Summary
Fixes iMessage media-only sends to explicit chat targets by routing them through
imsg send-attachment --transport autoinstead of the generic RPCsendpayload with a file path.Why
While testing issue #83365, normal iMessage group image replies generated the PNG but did not deliver a media attachment. Direct
imsg send-rich --filealso failed on the same group with an IMCore attachment staging error, whileimsg send-attachment --transport autosucceeded and produced a real attachment row. DM media sends by handle already worked, so this keeps handle/DM sends on the existing path and only changes explicit chat media-only sends (chat_id/chat_guid).Changes
chat_idto a chat GUID when needed and callsend-attachment --transport auto.Validation
pnpm format:check -- extensions/imessage/src/send.ts extensions/imessage/src/send.test.tspnpm vitest run extensions/imessage/src/send.test.ts extensions/imessage/src/actions.runtime.test.tspnpm tsgo:extensionsLive Evidence
On the Lobster Mac, the same generated PNG failed via
imsg send-rich --filefor the group, but succeeded viaimsg send-attachment --transport autoand produced an image attachment in the group chat.Fixes #83365