fix(diagnostics): expose missing telemetry signals#86682
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(diagnostics): expose missing telemetry signals This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
bab3ec4 to
607b9b8
Compare
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 26, 2026
4 tasks
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
SYU8384
pushed a commit
to SYU8384/openclaw
that referenced
this pull request
Jun 3, 2026
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/traces,/v1/metrics, and/v1/logsare inserted before query strings or fragments.Verification
AUTOREVIEW_AUTO_TESTS=0 AUTOREVIEW_OPENCLAW_MAINTAINER_VALIDATION=1 .agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main-> clean, no accepted/actionable findings.run_cf9cee226993, leasecbx_e9567e71c6b2, provider AWS c7a.8xlarge:pnpm test:serial src/infra/diagnostic-events.test.ts extensions/diagnostics-otel/src/service.test.ts extensions/diagnostics-prometheus/src/service.test.ts && pnpm check:changed && pnpm qa:observability:smoke && pnpm qa:observability:collector-smoke.pnpm check:changedpassed core, coreTests, extensions, extensionTests, and docs lanes.otel/opentelemetry-collector:0.104.0: OTel spans=18 metrics=28 logs=14 traces=2 metricRequests=6 logRequests=5; Prometheus smoke passed.Real behavior proof
Behavior addressed: Operators now get correct OTLP signal URLs when a shared endpoint has query strings/fragments, explicit OTel metrics for blocked tools/model failover/large payloads, and Prometheus metrics for gateway stability signals without accepting plugin-spoofed untrusted diagnostics.
Real environment tested: AWS Crabbox Linux runner, provider
aws, leasecbx_e9567e71c6b2, runrun_cf9cee226993, including in-process OTLP/Prometheus QA and a Docker OpenTelemetry Collector path.Exact steps or command run after this patch:
pnpm test:serial src/infra/diagnostic-events.test.ts extensions/diagnostics-otel/src/service.test.ts extensions/diagnostics-prometheus/src/service.test.ts && pnpm check:changed && pnpm qa:observability:smoke && pnpm qa:observability:collector-smoke.Evidence after fix: Focused regression tests covered endpoint query/fragment handling, new OTel instruments, Prometheus stability metrics, and plugin-spoofed untrusted diagnostic drops. QA smoke exported OTLP/Prometheus data successfully both directly and through
otel/opentelemetry-collector:0.104.0.Observed result after fix: The remote command exited 0. In-process OTel smoke observed spans=18, metrics=37, logs=14, traces=2, metricRequests=7, logRequests=6. Collector smoke observed spans=18, metrics=28, logs=14, traces=2, metricRequests=6, logRequests=5. Prometheus smoke passed in both lanes.
What was not tested: Live third-party Prometheus/Grafana scraping and live external provider traffic were not exercised; the proof used repository QA scenarios and a real OpenTelemetry Collector container.