test: derive deprecated SDK usage guard#86403
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 25, 2026, 4:57 AM ET / 08:57 UTC. Summary PR surface: Tests +23, Other +12. Total +35 across 3 files. Reproducibility: not applicable. this is a scripts/test cleanup PR rather than a reported runtime bug. Source inspection confirmed the current hard-coded guard and the existing curated inventory that the PR derives from. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge Security Review detailsBest possible solution: Land the guard derivation after normal required checks confirm the script and focused Vitest test pass, keeping the curated deprecated SDK inventory as the single source of truth with explicit root/private aliases. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a scripts/test cleanup PR rather than a reported runtime bug. Source inspection confirmed the current hard-coded guard and the existing curated inventory that the PR derives from. Is this the best way to solve the issue? Yes; deriving the guard from the existing curated inventory is narrower and less drift-prone than maintaining a second manual list, and the explicit extras preserve root/private alias handling. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 912fdfbedd5a. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +23, Other +12. Total +35 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg ✨ Hatched: 💎 rare Frosted Crabkin Hatch commandComment Hatchability rules:
Rarity: 💎 rare. What is this egg doing here?
|
|
Landing verification for #86403: Behavior addressed: deprecated plugin SDK usage guard now derives banned deprecated public subpaths from |
Summary
Verification