fix(telegram): honor table mode in outbound chunks#85455
Conversation
|
Codex review: needs real behavior proof before merge. Latest ClawSweeper review: 2026-05-22 17:24 UTC / May 22, 2026, 1:24 PM ET. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. source inspection gives a high-confidence path: call PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Merge the focused table-mode threading after adding visible Telegram proof that a chunked Markdown table with Do we have a high-confidence way to reproduce the issue? Yes, source inspection gives a high-confidence path: call Is this the best way to solve the issue? Yes, the PR is the narrow maintainable fix for the functional bug because it reuses the existing outbound formatting contract and keeps explicit HTML parse-mode chunking unchanged. Label changes:
Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 87b204657570. |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
defd48c to
78cfe7e
Compare
78cfe7e to
d914881
Compare
d914881 to
e697596
Compare
e697596 to
4d3223a
Compare
Summary:
formatting.tableModeinto Telegram markdown chunk renderingVerification:
pnpm test extensions/telegram/src/telegram-outbound.test.ts.agents/skills/autoreview/scripts/autoreview --mode localBehavior addressed:
Telegram outbound markdown chunking accepted formatting metadata but dropped
tableMode, so table rendering could differ from the configured Telegram markdown behavior once messages were chunked.Real environment tested:
Local macOS checkout with the Telegram extension Vitest shard.
Exact steps or command run after this patch:
pnpm test extensions/telegram/src/telegram-outbound.test.tsEvidence after fix:
The outbound adapter test now sends a markdown table through the chunker with
formatting.tableMode: "bullets"and verifies the rendered chunk contains the bullet-form table content instead of the raw table syntax.Observed result after fix:
1 Vitest file passed, 3 tests passed; autoreview reported no accepted/actionable findings.
What was not tested:
A live Telegram send; the fix is isolated to the deterministic outbound markdown chunker before network delivery.
Fixes #85085.