fix(cron): classify network retry errors#85344
Merged
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(cron): classify network retry errors This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Contributor
Author
|
Landed in ebfb834. Proof:
|
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
galiniliev
pushed a commit
to galiniliev/openclaw
that referenced
this pull request
May 25, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
SYU8384
pushed a commit
to SYU8384/openclaw
that referenced
this pull request
Jun 3, 2026
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveCronExecutionRetryHint.EAI_AGAIN,EHOSTUNREACH,EHOSTDOWN,ENETRESET,ENETUNREACH,EPIPE) asnetworkwhencron.retry.retryOnis restricted tonetwork.Verification
pnpm format:check CHANGELOG.md src/cron/retry-hint.ts src/cron/retry-hint.test.ts src/cron/service/timer.tsgit diff --checkpnpm check:changedvia Testboxtbx_01ks7rp7bzvzc9gx16k5q1nt9enode scripts/run-vitest.mjs src/cron/retry-hint.test.tsvia Testboxtbx_01ks7rtr8a6a50fvpnv3b9djsh(3 passed)/Users/steipete/Projects/agent-scripts/skills/autoreview/scripts/autoreview --mode local(clean)Behavior addressed: one-shot cron jobs with
cron.retry.retryOn: ["network"]could skip retrying common network-code failures such asEAI_AGAINbecause those codes were classified outside the small cron network regex.Real environment tested: Blacksmith Testbox through Crabbox, provider
blacksmith-testbox.Exact steps or command run after this patch:
node scripts/run-vitest.mjs src/cron/retry-hint.test.tsandpnpm check:changed.Evidence after fix: focused Testbox run
tbx_01ks7rtr8a6a50fvpnv3b9djshpassed 3 retry-hint tests; changed gatetbx_01ks7rp7bzvzc9gx16k5q1nt9eexited 0.Observed result after fix: network-only retry policy now marks those network-code strings retryable with category
network.What was not tested: no live provider outage was induced; this is deterministic cron retry classification coverage plus CI-parity changed checks.