fix(infra): allow macOS browser open over SSH env#85340
Conversation
|
Codex review: needs real behavior proof before merge. Latest ClawSweeper review: 2026-05-22 12:58 UTC / May 22, 2026, 8:58 AM ET. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. from source inspection: current main returns PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Keep the narrow macOS exception if maintainers accept the behavior change, backed by focused tests plus redacted live macOS SSH-env proof or an explicit maintainer proof override. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main returns Is this the best way to solve the issue? Yes. Excluding Label changes:
Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against a00c58363a4f. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
e3e821b to
aef1604
Compare
aef1604 to
6ffbbb4
Compare
Summary
openeven when SSH environment variables are present.Verification
Behavior addressed:
openclaw dashboard/browser launch helpers no longer misclassify macOS shells withSSH_CONNECTIONas headless whenopenis available.Real environment tested: local macOS source checkout with platform/env branches mocked in unit tests.
Exact steps or command run after this patch:
node scripts/run-vitest.mjs src/infra/browser-open.test.ts;git diff --check;.agents/skills/autoreview/scripts/autoreview --mode localEvidence after fix: regression test verifies macOS +
SSH_CONNECTIONresolves{ argv: ["open"], command: "open" }, while Linux + SSH without display still returnsssh-no-display.Observed result after fix: focused test passed, diff check passed, autoreview reported no accepted/actionable findings.
What was not tested: live browser opening from an SSH-launched macOS terminal.
Fixes #67088