fix(cli): suppress systemd hints for live gateway#85336
Conversation
|
Codex review: needs real behavior proof before merge. Latest ClawSweeper review: 2026-05-22 12:18 UTC / May 22, 2026, 8:18 AM ET. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. source-reproducible: the linked report gives concrete Linux system-unit steps, and current main formats top-level service rows without considering PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Risk before merge
Maintainer options:
Next step before merge Security Review findings
Review detailsBest possible solution: Update the top-level status overview or service-summary path so a reachable Gateway suppresses or reclassifies user-systemd Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible: the linked report gives concrete Linux system-unit steps, and current main formats top-level service rows without considering Is this the best way to solve the issue? No. Suppressing the daemon-printer hint is useful but not sufficient; the fix should cover the top-level Label justifications:
Full review comments:
Overall correctness: patch is incorrect What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 84329182a7c4. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
6caddd5 to
1531ebc
Compare
7bccc66 to
1becfa8
Compare
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
* fix(cli): suppress systemd hints for live gateway * test(cli): type systemd hint mock
Summary
openclaw status --deepfrom printing systemd user-service setup hints when Gateway RPC is already reachable.Verification
Behavior addressed: status output no longer reports a false systemd user-service problem for externally managed/system-scoped Gateways that respond over RPC.
Real environment tested: local macOS source checkout with Linux platform mocked in the focused unit test.
Exact steps or command run after this patch:
node scripts/run-vitest.mjs src/cli/daemon-cli/status.print.test.ts;git diff --check;.agents/skills/autoreview/scripts/autoreview --mode localEvidence after fix: regression test forces
isSystemdUnavailableDetail()true withrpc.ok: trueand asserts the systemd hints are not printed.Observed result after fix: focused test passed, diff check passed, autoreview reported no accepted/actionable findings.
What was not tested: live Linux systemd system-service Gateway install.
Fixes #85094