feat(tui): coalesce repeated idle TUI abort notices#85167
Conversation
|
Codex review: needs maintainer review before merge. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. from source inspection: current PR rating What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Next step before merge Security Review detailsBest possible solution: Land this after normal maintainer review and CI, keeping the coalescing opt-in to the idle abort notice so other TUI system messages remain unchanged. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current Is this the best way to solve the issue? Yes; the PR uses a narrow opt-in coalescing path on the one noisy idle-abort notice and preserves ordinary system-message behavior. Label changes:
Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 60d200f79719. |
|
ClawSweeper PR egg ✨ Hatched: 🌱 uncommon Velvet Test Hopper Hatch commandComment Hatchability rules:
Rarity: 🌱 uncommon. What is this egg doing here?
|
Summary
BEFORE
AFTER
xNsuffix.no active runnotices no longer spam the terminal.Verification
pnpm installnode scripts/run-vitest.mjs src/tui/components/chat-log.test.ts src/tui/tui-session-actions.test.tsAUTOREVIEW_AUTO_TESTS=0 .agents/skills/autoreview/scripts/autoreview --mode localgit diff --checkReal behavior proof
Behavior addressed: Pressing Esc repeatedly in the TUI with no active run now keeps one
no active runsystem row and increments it asx2,x3, etc.Real environment tested: Local OpenClaw checkout on macOS with Node 22.22.0 and pnpm 11.1.0.
Exact steps or command run after this patch:
node scripts/run-vitest.mjs src/tui/components/chat-log.test.ts src/tui/tui-session-actions.test.tsEvidence after fix: The focused tests cover consecutive repeatable system-message coalescing, ordinary system-message non-coalescing, reset after user content, and the idle abort path passing
coalesceConsecutive: true.Observed result after fix: 2 test files passed, 23 tests passed.
What was not tested: Manual interactive TUI keypress behavior was not live-driven; coverage is through the chat-log rendering and abort action unit tests.