Show assistant commentary in Discord progress drafts#85164
Conversation
|
Codex review: needs maintainer review before merge. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: not applicable. as a feature/config PR. Source inspection shows current main already emits preamble item events, and the branch wires those events into Discord progress drafts behind the new opt-in setting. PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land the narrow opt-in Discord progress-commentary path after maintainer approval and normal checks, keeping default behavior off and final replies unchanged. Do we have a high-confidence way to reproduce the issue? Not applicable as a feature/config PR. Source inspection shows current main already emits preamble item events, and the branch wires those events into Discord progress drafts behind the new opt-in setting. Is this the best way to solve the issue? Yes, pending maintainer product approval. The patch uses the existing preamble item event contract, defaults the new behavior off, keeps final replies unchanged, and covers the key delivery guards with focused tests. Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against c8a35c4645dc. |
7a412ee to
631cfd8
Compare
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Frosted Review Wisp Hatch commandComment Hatchability rules:
Rarity: 🥚 common. What is this egg doing here?
|
631cfd8 to
b2abdbd
Compare
|
@clawsweeper re-review Addressed the review feedback on the current head:
Local validation remains: |
b2abdbd to
95c6b01
Compare
|
@clawsweeper re-review Fresh head after no-op amend is |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper ask demo feature using ascii |
|
🦞👀 I queued a lightweight read-only assist pass. It will post a separate answer comment and will not edit the durable ClawSweeper review comment or trigger close, merge, repair, label, or branch changes. Request: demo feature using ascii |
|
ClawSweeper assist: ASCII demo of the feature behavior: With this PR’s config, commentary can show in the temporary Discord draft while tool rows stay hidden: {
"streaming": {
"mode": "progress",
"progress": {
"commentary": true,
"toolProgress": false,
"label": false
}
}
}Evidence:
Suggested next action: For a real visual proof demo, ask for a short redacted Discord capture showing the temporary commentary draft and the normal final reply. Source: #85164 (comment) |
|
@clawsweeper automerge |
|
🦞🔧
Draft PRs stay fix-only until GitHub marks them ready for review. Pause with Automerge progress:
|
|
🦞✅ Source: Why human review is needed: What the maintainer can do as a next step: I added |
|
ClawSweeper 🐠 reef update Thanks for the contribution here. ClawSweeper could not safely push to this branch, so it opened a replacement PR from a writable branch and carried the contributor trail along with it. Why replacement: ClawSweeper could not update the source PR branch directly; GitHub did not grant sufficient push rights to the bot for that branch.
fish notes: model gpt-5.5, reasoning high; reviewed against d30206a. |
Summary
Fixes #83307.
Adds an opt-in Discord progress-streaming path for assistant commentary/preamble text. When
channels.discord.streaming.modeis"progress"andchannels.discord.streaming.progress.commentaryistrue, Discord renders Codex preamble/commentary item events in the temporary progress draft while keeping final answer delivery unchanged.Behavior
streaming.progress.commentaryto the shared channel streaming config schema, defaulting off.kind: "preamble"item events in the Discord progress draft path.toolProgress, so tool rows can stay hidden while commentary remains visible.NO_REPLYcommentary.Docs
streaming.progress.commentaryindocs/channels/discord.md.Real behavior proof
toolProgress: false; final answer delivery remains the normal durable Discord reply.channels.discord.streaming.mode: "progress",progress.commentary: true,progress.toolProgress: false, andprogress.label: false.toolProgress: false,NO_REPLY/inline directive text did not appear in commentary tests, late commentary after final delivery start did not edit the progress draft, and the final answer was delivered normally.Validation
pnpm vitest run --config test/vitest/vitest.plugin-sdk.config.ts src/plugin-sdk/channel-streaming.test.tspnpm vitest run --config test/vitest/vitest.extension-discord.config.ts extensions/discord/src/monitor/message-handler.process.test.tspnpm config:schema:checkpnpm config:channels:checkpnpm check:changed