fix(dreaming): open report cards from Memory Palace#85144
Conversation
|
Codex review: needs maintainer review before merge. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. Current main accepts report-kind Memory Palace items, but the primary card click handler toggles details for every kind while the existing preview path is only on the secondary Open wiki page button. PR rating What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land the narrow report-kind click routing change with the focused regression tests, keeping the explicit Details button and non-report card expansion behavior unchanged. Do we have a high-confidence way to reproduce the issue? Yes. Current main accepts report-kind Memory Palace items, but the primary card click handler toggles details for every kind while the existing preview path is only on the secondary Open wiki page button. Is this the best way to solve the issue? Yes. Reusing the existing wiki preview flow for report-kind primary clicks is the narrow maintainable fix, and the explicit Details button plus non-report primary click behavior remain intact. Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 229490a48924. |
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Clockwork Signal Puff Hatch commandComment Hatchability rules:
Rarity: 🥚 common. What is this egg doing here?
|
|
Added running UI proof for PR head Environment:
Flow verified:
Observed result: {
"viewport": "390x844 mobile",
"nonReportDetailsVisible": true,
"openedPath": "reports/weekly-stock.md",
"previewTitle": "Weekly stock report",
"previewBody": "# Weekly stock report\n\nSummary content.",
"pageDetailsVisibleForReportCard": false,
"relevantConsole": [],
"domHasPreview": true
}This covers the mobile report-card primary click path and the preserved non-report details path. |
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Added original running-UI visual proof from a real local gateway/profile, not a component fixture. Setup used for the proof:
Result:
Synthesis card keeps details behavior:
Report card opens wiki preview:
|
|
@clawsweeper re-review |
RomneyDa
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Summary
Fixes #54749
Verification
node scripts/run-vitest.mjs ui/src/ui/views/dreaming.test.tspnpm exec oxfmt --check --threads=1 ui/src/ui/views/dreaming.ts ui/src/ui/views/dreaming.test.tsgit diff --check origin/main..HEADpnpm check:changedReal behavior proof
Behavior addressed: Memory Palace report cards now open the report/wiki content preview on primary click instead of expanding the metadata details panel.
Real environment tested: Local OpenClaw checkout on macOS with Node v24.10.0 and pnpm 11.1.0.
Exact steps or command run after this patch:
node scripts/run-vitest.mjs ui/src/ui/views/dreaming.test.tsEvidence after fix: The regression test clicks a
kind: "report"Memory Palace card and verifiesonOpenWikiPage("reports/weekly-stock.md")runs, the preview shows "Weekly stock report", and the details panel does not open. The adjacent non-report test clicks a synthesis card and verifies it still opens "Page details".Observed result after fix: Report-card primary clicks route to the existing wiki preview; non-report card primary clicks preserve the previous details behavior.
What was not tested: I did not run a live mobile browser against a running gateway.