fix(models) Discord model picker doesn't list all models#85138
Conversation
|
Codex review: needs changes before merge. Latest ClawSweeper review: 2026-05-22 06:33 UTC / May 22, 2026, 2:33 AM ET. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. at source level: current main computes provider/model pages but exposes no nav controls, and the focused tests explicitly assert navigation is absent for over-limit provider counts. I did not run a live current-main Discord repro in this read-only review. PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review findings
Review detailsBest possible solution: Land the pagination fix after the focused Discord model picker tests cover provider and model navigation rows, preserved state, and the current-model initial-page behavior. Do we have a high-confidence way to reproduce the issue? Yes at source level: current main computes provider/model pages but exposes no nav controls, and the focused tests explicitly assert navigation is absent for over-limit provider counts. I did not run a live current-main Discord repro in this read-only review. Is this the best way to solve the issue? Yes directionally: adding Discord component pagination at the picker layer is the narrow maintainable fix for the 25-button/select-option limits. The implementation should not merge until the focused tests are updated to match and protect that new contract. Label changes:
Label justifications:
Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against d0a74dbfbe4d. |
|
ClawSweeper PR egg 🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress. Hatch commandComment Hatchability rules:
What is this egg doing here?
|
93a6272 to
3111e87
Compare
|
@clawsweeper review please |
|
🦞👀 I queued a lightweight read-only assist pass. It will post a separate answer comment and will not edit the durable ClawSweeper review comment or trigger close, merge, repair, label, or branch changes. Request: review please |
|
@clawsweeper re-review |
|
ClawSweeper assist: This asks for a full correctness review, so use Evidence:
Suggested next action: Wait for the Source: #85138 (comment) |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Add pagination to Discord model picker
Untitled.mov
Previously the Discord
/modelspicker only showed the first page of providers and the first 25 models per provider — Discord component limits cap the provider grid at 25 buttons and each select menu at 25 options. Users with >25 providers or any provider with >25 models (openai, anthropic, etc.) couldn't see the rest of the catalog.Adds a
[◀ Prev | Page X/Y | Next ▶]row to both views whentotalPages > 1:provider: page X/Y · N modelsline.Page indicator is a disabled informational button; prev/next disable at endpoints. Custom_id encodes the target page plus the surrounding state (selected provider, runtime, pending model) so flipping pages preserves the picker's selection. Row budget worst case is 5 in both views, within
DISCORD_COMPONENT_MAX_ROWS.