Fix Discord session recovery abort ownership#85100
Conversation
|
Codex review: needs maintainer review before merge. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. The linked issue includes live Discord stuck-session logs, and current-main source inspection shows dispatch work reaches hooks/resolver without a dispatch-owned reply operation that PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land the source-keyed dispatch operation approach after maintainers confirm the exact head has green CI and enough Discord/ACP stop proof for source-vs-target ownership and late-reply suppression. Do we have a high-confidence way to reproduce the issue? Yes. The linked issue includes live Discord stuck-session logs, and current-main source inspection shows dispatch work reaches hooks/resolver without a dispatch-owned reply operation that Is this the best way to solve the issue? Yes, with maintainer validation. Registering one reply operation before hook/model dispatch and threading it into Label changes:
Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 26e64bda1485. |
|
ClawSweeper PR egg ✨ Hatched: 🌱 uncommon Frosted Review Wisp Hatch commandComment Hatchability rules:
Rarity: 🌱 uncommon. What is this egg doing here?
|
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
* fix auto-reply abort ownership * add changelog for openclaw#85100
Summary:
Verification:
Behavior addressed: Discord/session-key recovery now has a source-keyed dispatch operation before hooks/model dispatch so /stop and stuck-session recovery can find and abort pre-run work; bound ACP routing remains target-keyed while abort ownership stays source-keyed.
Real environment tested: Discord live QA and ACP live bind/stop scenarios were previously run on this branch during issue proof; AWS Crabbox attempts were made but provider capacity was unavailable for the earlier runs.
Exact steps or command run after this patch: focused local proof commands listed above; earlier live proof covered Discord canary/mention/native-help, Discord status/tool-only, ACP live bind/follow-up, and stop/recovery E2E.
Evidence after fix: focused ACP/abort Vitest passed 40 tests after the final rebase resolution; core and core-test tsgo both passed; final direct Codex review exited with no accepted findings.
Observed result after fix: aborted dispatches resolve as handled without queuing late tool/block/final replies, /stop does not self-abort its own command, and bound ACP source lanes remain abortable while ACP dispatch still routes to the target session.
What was not tested: a fresh AWS Crabbox proof after the final rebase resolution, because the earlier AWS Crabbox provider attempts were unavailable; CI will provide the broad hosted proof for this pushed branch.
Fixes #84477