fix(qa-lab): rename codex lifecycle fixtures to match knip ignore pattern#85066
Merged
Conversation
…tern knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(qa-lab): rename codex lifecycle fixtures to match knip ignore pattern This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in d818b93 as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
galiniliev
pushed a commit
to galiniliev/openclaw
that referenced
this pull request
May 25, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in a8c3720 as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
SYU8384
pushed a commit
to SYU8384/openclaw
that referenced
this pull request
Jun 3, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in bbf3eec as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
…tern (openclaw#85066) knip's deadcode-unused-files check ignores fixtures matching **/*.fixture.ts (dot before "fixture"). The codex lifecycle fixtures landed in 80c5418 as auth-profile-fixture.ts and codex-plugin-fixture.ts (hyphen), so knip flagged them as unexpected unused files and CI's check-dependencies job has been failing on main since then. Rename to auth-profile.fixture.ts and codex-plugin.fixture.ts and update the lifecycle test, the fixture cross-import, and the six qa/scenarios markdown files that reference them by path and qaImport specifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`knip`'s deadcode-unused-files check ignores fixtures matching `**/*.fixture.ts` (dot before `fixture`) — see `config/knip.config.ts:113-114`. The codex lifecycle fixtures landed in `bbf3eec786` as `auth-profile-fixture.ts` and `codex-plugin-fixture.ts` (hyphen, not dot), so the check has flagged them as unexpected unused files and CI's `check-dependencies` job has been failing on `main` since then.
Rename to the dotted form to match the convention, and update every reference:
Net diff: +21/-21 across 9 files (true renames preserved by git, content unchanged inside the fixtures).
Verification
Behavior addressed: `check-dependencies` job failing on `main` and on every open PR's CI because of the two newly-added `-fixture.ts` files being unmatched by the knip ignore pattern.
Real environment tested: local macOS Darwin 25.2.0, fresh worktree off `origin/main` at `b25a0d013b`.
Exact steps or command run after this patch:
Evidence after fix: `git log -1 --stat` shows two true renames (100% / 99% similarity) — content of the fixtures themselves is unchanged. Test imports and `qaImport()` specifiers in the scenario manifests are updated to the new `.fixture.js` form.
Observed result after fix: `check-dependencies` should pass on this branch and unblock every open PR.
What was not tested: the qa lifecycle test suite was not executed locally in the fresh worktree (no `pnpm install` per repo policy on worktrees); the rename is mechanical and the import updates are exhaustive per grep. CI will exercise the test suite.
Thanks @RomneyDa.