feat: support git and local skill installs#84793
Conversation
|
Codex review: needs real behavior proof before merge. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: not applicable. this is a feature PR rather than a bug report. Source inspection confirms current PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Keep the PR open for maintainer approval of the Git/local skill install surface, add redacted real CLI proof, and land only if maintainers accept the non-ClawHub source boundary. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a feature PR rather than a bug report. Source inspection confirms current Is this the best way to solve the issue? Yes, with merge gates: reusing the existing skill installer/security scan and ClawHub untracking is the maintainable boundary. The remaining question is maintainer acceptance plus real behavior proof for the new CLI path. Label changes:
Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against a30ac3f8d7cb. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
Summary
openclaw skills install git:owner/repo[@ref]and local directory source installsSKILL.mdfrontmatter, with--asoverrides and ClawHub-only--versionVerification
node scripts/run-vitest.mjs src/cli/skills-cli.commands.test.ts src/agents/skills-source-install.test.ts src/plugins/git-install.test.ts src/process/exec.test.tspnpm exec oxfmt --check --threads=1 src/plugins/git-install.ts src/plugins/git-install.test.ts src/agents/skills-source-install.test.tspnpm exec oxfmt --check --threads=1 docs/tools/skills.md docs/cli/skills.mdpnpm docs:listgit diff --checkAUTOREVIEW_AUTO_TESTS=0 .agents/skills/autoreview/scripts/autoreview --parallel-tests "node scripts/run-vitest.mjs src/cli/skills-cli.commands.test.ts src/agents/skills-source-install.test.ts src/plugins/git-install.test.ts src/process/exec.test.ts"Real Behavior Proof
Behavior addressed:
openclaw skills installcan install from ClawHub slugs,git:specs, and local skill directories while keeping ClawHub update behavior scoped to ClawHub-tracked installs.Real environment tested: local Codex worktree on macOS using focused Vitest coverage and the repo autoreview helper.
Exact steps or command run after this patch:
node scripts/run-vitest.mjs src/cli/skills-cli.commands.test.ts src/agents/skills-source-install.test.ts src/plugins/git-install.test.ts src/process/exec.test.ts.Evidence after fix: focused tests passed with 5 files and 70 tests, including local directory installs, git installs, slash-containing refs, authenticated URL parsing, stale ClawHub metadata cleanup, and ClawHub route preservation.
Observed result after fix: final autoreview reported
autoreview clean: no accepted/actionable findings reported.What was not tested: live network install from a remote GitHub repository was not run; git behavior is covered with local git repositories and parser tests.