fix(minimax): stop advertising music duration control#84765
Conversation
|
Codex review: passed. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the request body has no structured duration field and only appends a natural-language hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land this PR after exact-head checks pass and maintainers accept that MiniMax Do we have a high-confidence way to reproduce the issue? Yes, by source inspection: current main advertises MiniMax duration support while the request body has no structured duration field and only appends a natural-language hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Is this the best way to solve the issue? Yes. Removing the advertised capability and prompt hint is the narrowest maintainable fix until MiniMax documents a structured duration request field; the shared runtime already reports unsupported overrides. Label changes:
Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against c4f14a39a520. |
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Gilded Proofling Hatch commandComment Hatchability rules:
Rarity: 🥚 common. What is this egg doing here?
|
|
🦞✅ Source: What merged:
Automerge notes:
The automerge loop is complete. Automerge progress:
|
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The PR removes MiniMax music duration support from provider capabilities and docs, stops prompt-injecting duration hints, updates the MiniMax provider test, and adds a changelog entry. - Reproducibility: yes. by source inspection: current main advertises MiniMax duration support while the reque ... uage hint. I did not rerun a live pre-fix MiniMax request, but the code path and vendor contract are clear. Automerge notes: - PR branch already contained follow-up commit before automerge: docs(minimax): align music controls - PR branch already contained follow-up commit before automerge: docs(music): remove minimax duration steering claim - PR branch already contained follow-up commit before automerge: fix(minimax): stop advertising music duration control Validation: - ClawSweeper review passed for head 1c616da. - Required merge gates passed before the squash merge. Prepared head SHA: 1c616da Review: openclaw#84765 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Makes #84585 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
Known failing checks:
ClawSweeper 🐠 replacement reef notes:
Inherited issue-closing references from the source PR:
Fixes #84508
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against 1c616da.