fix(doctor): warn when sandbox hides MCP tools#84742
Conversation
|
Codex review: passed. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second gate for plugin-owned bundled MCP tools, and the source PR supplies after-patch live PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Merge through the armed automerge lane once exact-head checks remain green, keeping runtime behavior unchanged and documenting the MCP sources this diagnostic does not enumerate yet. Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible. Runtime policy inspection shows sandbox tool policy is a second gate for plugin-owned bundled MCP tools, and the source PR supplies after-patch live Is this the best way to solve the issue? Yes. The patch keeps the fix in doctor diagnostics, mirrors the relevant sandbox policy fallback path, adds focused coverage, and avoids changing runtime tool filtering or provider serialization. Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 2c0c9c92f485. |
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Tiny Branchling Hatch commandComment Hatchability rules:
Rarity: 🥚 common. What is this egg doing here?
|
|
🦞✅ Source: What merged:
Automerge notes:
The automerge loop is complete. Automerge progress:
|
21051c1 to
12785c6
Compare
Co-authored-by: David <32288+nxmxbbd@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: David <32288+nxmxbbd@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
55c71de to
79dfc3e
Compare
|
@clawsweeper automerge |
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - This bot replacement PR adds an `openclaw doctor` warning, regression coverage, gateway docs, and a changelog entry for sandbox tool policies that hide configured MCP server tools. - Reproducibility: yes. source-reproducible. Runtime policy inspection shows sandbox tool policy is a second g ... ed MCP tools, and the source PR supplies after-patch live `openclaw doctor` output showing the new warning. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(doctor): mirror sandbox policy fallback - PR branch already contained follow-up commit before automerge: fix(doctor): preserve sandbox deny diagnostics - PR branch already contained follow-up commit before automerge: fix(doctor): polish sandbox MCP warnings - PR branch already contained follow-up commit before automerge: fix(doctor): warn when sandbox hides MCP tools - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8469… Validation: - ClawSweeper review passed for head 79dfc3e. - Required merge gates passed before the squash merge. Prepared head SHA: 79dfc3e Review: openclaw#84742 (comment) Co-authored-by: David Huang <nxmxbbd@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Makes #84699 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
Known failing checks:
ClawSweeper 🐠 replacement reef notes:
Inherited issue-closing references from the source PR:
Closes #80909
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against 21051c1.