fix(code-mode): sharpen exec tool description so models stop wasting turns rediscovering constraints#84368
Conversation
|
Codex review: passed. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mode runtime and reference docs already enforce. The linked source PR also includes a live before/after recitation path showing the model receives the changed tool description. PR rating What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Next step before merge Security Review detailsBest possible solution: Land the schema-text, regression-test, and changelog update if the exact repaired head remains green, preserving the id-based catalog bridge wording. Do we have a high-confidence way to reproduce the issue? Yes at source level: current main's exec schema omits constraints that the current code-mode runtime and reference docs already enforce. The linked source PR also includes a live before/after recitation path showing the model receives the changed tool description. Is this the best way to solve the issue? Yes. A description-only schema update with focused assertions is the narrowest maintainable fix because the runtime behavior and catalog bridge already exist. Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against ff5354ee4fbd. |
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Pearl Test Hopper Rarity: 🥚 common. What is this egg doing here?
|
|
🦞✅ Source: What merged:
Automerge notes:
The automerge loop is complete. Automerge progress:
|
…turns rediscovering constraints When tools.codeMode.enabled is true, the exec tool's description tells the model to use tools.search/describe/call to call enabled tools, but does not state any of the runtime's actual constraints. Observed traces show models waste turns rediscovering them: trying language: "bash", writing require() for I/O, and probing scope by trial and error. This change tells the model up front: - Node modules and require/import are NOT available - language accepts only "javascript" or "typescript" - the tools.search → describe → call bridge is the path to any shell, file, network, or external action - which symbols are in scope (tools, ALL_TOOLS) versus what is not No runtime behavior changes — only the tool-card description strings. Snapshot tests do not reference either old string (verified via grep).
…turns rediscovering constraints
…turns rediscovering constraints
ae25826 to
8ff8507
Compare
…turns rediscovering constraints (#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff85071ce232f542834019efb44eef8c8091e91. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff85071ce232f542834019efb44eef8c8091e91 Review: openclaw/openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff85071ce232f542834019efb44eef8c8091e91. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff85071ce232f542834019efb44eef8c8091e91 Review: openclaw/openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…turns rediscovering constraints (openclaw#84368) Summary: - The PR updates the code-mode exec tool description, adds regression coverage for the model-visible constraints, and records the fix in the changelog. - Reproducibility: yes. at source level: current main's exec schema omits constraints that the current code-mo ... also includes a live before/after recitation path showing the model receives the changed tool description. Automerge notes: - PR branch already contained follow-up commit before automerge: test(code-mode): cover exec tool guidance - PR branch already contained follow-up commit before automerge: fix(code-mode): sharpen exec tool description so models stop wasting … Validation: - ClawSweeper review passed for head 8ff8507. - Required merge gates passed before the squash merge. Prepared head SHA: 8ff8507 Review: openclaw#84368 (comment) Co-authored-by: Kaspre <kaspre@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Makes #84269 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
ClawSweeper 🐠 replacement reef notes:
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against ae25826.