fix(channels): suppress verbose failed-tool dumps#84354
Conversation
|
Codex review: passed. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool output escaping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Land the branch after exact-head validation if maintainers accept regular verbose as compact progress and reserve raw failed-tool detail for Do we have a high-confidence way to reproduce the issue? Yes. The current-main source path and supplied before screenshot show failed text-only tool output escaping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Is this the best way to solve the issue? Yes, with maintainer acceptance of the compatibility split. The patch fixes the shared error classification and final-delivery gates while preserving Label justifications:
Acceptance criteria:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 29f8715f05c8. |
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Tiny Clawlet Hatch commandComment Hatchability rules:
Rarity: 🥚 common. What is this egg doing here?
|
|
🦞✅ Source: Why human review is needed: Recommended next action: I added |
|
@clawsweeper automerge I approve of the merge |
|
🦞🧹
Draft PRs stay fix-only until GitHub marks them ready for review. Pause with Automerge progress:
|
This reverts commit dbe415b.
Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
4aa5c96 to
d15ae69
Compare
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae6951b94f8a9851626cea6e7ed4dd17e88ea. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae6951b94f8a9851626cea6e7ed4dd17e88ea Review: openclaw/openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae6951b94f8a9851626cea6e7ed4dd17e88ea. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae6951b94f8a9851626cea6e7ed4dd17e88ea Review: openclaw/openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Summary: - The branch suppresses regular verbose failed-tool raw output after final replies across shared dispatch, Codex, Telegram, and Discord paths, keeps raw detail under `/verbose full`, and updates tests, docs, and changelog. - Reproducibility: yes. The current-main source path and supplied before screenshot show failed text-only tool ... ping after a final reply; I did not rerun a live Telegram or Discord reproduction in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix message-tool delivery gating - PR branch already contained follow-up commit before automerge: fix(channels): keep verbose tool failures compact - PR branch already contained follow-up commit before automerge: fix(channels): suppress in-flight final progress - PR branch already contained follow-up commit before automerge: fix(replies): suppress failed tool dumps in message-only mode - PR branch already contained follow-up commit before automerge: fix(replies): avoid duplicate exec failure warnings - PR branch already contained follow-up commit before automerge: Revert "fix(replies): avoid duplicate exec failure warnings" Validation: - ClawSweeper review passed for head d15ae69. - Required merge gates passed before the squash merge. Prepared head SHA: d15ae69 Review: openclaw#84354 (comment) Co-authored-by: VACInc <3279061+VACInc@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Makes #84303 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
ClawSweeper 🐠 replacement reef notes:
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against 4aa5c96.