Preserve disabled Discord presentation buttons by clawsweeper[bot] · Pull Request #84312 · openclaw/openclaw

clawsweeper · 2026-05-19T20:56:52Z

Makes #84188 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-84188
Source PRs: Preserve disabled Discord presentation buttons #84188
Credit: Source PR: Preserve disabled Discord presentation buttons #84188
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Inherited issue-closing references from the source PR:
Closes #84183

Co-author credit kept:

@100menotu001: Co-authored-by: 100menotu001 64228916+100menotu001@users.noreply.github.com

fish notes: model gpt-5.5, reasoning high; reviewed against f01328f.

clawsweeper · 2026-05-19T20:57:55Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
Adds disabled to the message presentation button schema, advertises Discord disabled-button support, preserves the flag through Discord component mapping and link serialization, and adds regression tests plus a changelog entry.

Reproducibility: yes. Source inspection on current main shows disabled exists in the runtime type but is absent from the message tool schema, not advertised in Discord capabilities, dropped by adaptation, and omitted from Discord mapping/link serialization.

PR rating
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Summary: Above-average readiness: focused patch, source-backed root cause, targeted regression coverage, and sufficient runtime-output proof.

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Sufficient (live_output): The source PR body provides redacted runtime output showing after-fix adaptation, Discord component spec generation, and serialized link-button output preserving disabled: true.

Next step before merge
No repair lane is needed; this automerge-armed replacement should proceed through exact-head checks and normal merge gates.

Security
Cleared: No concrete security or supply-chain regression found; the diff only propagates an existing presentation flag and adds tests/changelog.

Review details

Best possible solution:

Land this focused replacement after exact-head checks, preserve the source contributor credit, and let #84183 close when the fix reaches main.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection on current main shows disabled exists in the runtime type but is absent from the message tool schema, not advertised in Discord capabilities, dropped by adaptation, and omitted from Discord mapping/link serialization.

Is this the best way to solve the issue?

Yes. The patch is the narrow owner-boundary fix: it propagates an existing presentation flag through the schema, capability metadata, Discord mapper, and builder paths without changing unrelated rendering behavior.

Label justifications:

P2: The PR fixes a real Discord presentation bug with a narrow channel-specific blast radius.
rating: 🦞 diamond lobster: Current PR rating is 🦞 diamond lobster because proof is 🦞 diamond lobster, patch quality is 🦞 diamond lobster, and Above-average readiness: focused patch, source-backed root cause, targeted regression coverage, and sufficient runtime-output proof.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (live_output): The source PR body provides redacted runtime output showing after-fix adaptation, Discord component spec generation, and serialized link-button output preserving disabled: true.
proof: sufficient: Contributor real behavior proof is sufficient. The source PR body provides redacted runtime output showing after-fix adaptation, Discord component spec generation, and serialized link-button output preserving disabled: true.

What I checked:

Current main runtime contract includes disabled buttons: MessagePresentationButton already exposes disabled?: boolean, so the reported behavior is a preservation bug rather than a new concept. (src/interactive/payload.ts:34, 88d8d6af9336)
Current main drops disabled controls unless the channel advertises support: adaptButton removes a disabled button when limits.actions.supportsDisabled is not true, while Discord's current capabilities omit that flag. (src/channels/plugins/outbound/presentation-limits.ts:206, 88d8d6af9336)
Current main message schema does not accept the field: The message tool presentation button schema lists label/value/url/web app/style fields but no disabled property. (src/agents/tools/message-tool.ts:155, 88d8d6af9336)
Current main Discord mapping and link serialization omit the field: The Discord presentation mapper does not copy button.disabled, and DynamicLinkButton does not override disabled even though LinkButton.serialize() emits it when set. (extensions/discord/src/shared-interactive.ts:53, 88d8d6af9336)
PR diff is focused on the implicated propagation path: The PR adds the schema field, supportsDisabled: true, Discord mapper propagation, disabled link-button serialization, targeted tests, and a changelog entry; the live file list shows no workflow, dependency, or secret-handling changes. (extensions/discord/src/outbound-adapter.ts:126, 9bb60d8cbf97)
Dependency contract supports disabled link buttons: Discord's Button object documentation includes disabled? and documents link buttons as URL-backed buttons without custom IDs, matching the PR's link-button serialization path. (docs.discord.com)

Likely related people:

Ayaan Zaidi: git blame on the central runtime type, adaptation limit, Discord capabilities, mapper, builder, and message schema lines points to 6da73ac. (role: current-main behavior introducer; confidence: high; commits: 6da73ac90f1e; files: src/interactive/payload.ts, src/channels/plugins/outbound/presentation-limits.ts, extensions/discord/src/outbound-adapter.ts)
Vincent Koc: History shows Vincent authored the original shared interactive renderer and channel centralization commits that established the affected Discord mapping surface. (role: original Discord/shared interactive contributor; confidence: medium; commits: 59d355bc4821, c7d31bae8a67, 1c78822a1f30; files: extensions/discord/src/shared-interactive.ts, extensions/discord/src/components.types.ts)
Peter Steinberger: History shows Peter authored the Discord mapper extraction and committed/merged adjacent interactive-rendering work in the affected area. (role: adjacent refactor author and merger; confidence: medium; commits: ff558862f079, 59d355bc4821, c7d31bae8a67; files: extensions/discord/src/shared-interactive.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 88d8d6af9336.

clawsweeper · 2026-05-19T21:03:31Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=9bb60d8cbf97064a271cd542e42d3be41ac50061)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-19T23:29:49Z
Merge commit: 97aa0c8c010c

What merged:

Adds disabled to the message presentation button schema, advertises Discord disabled-button support, prese ... through Discord component mapping and link serialization, and adds regression tests plus a changelog entry.
Reproducibility: yes. Source inspection on current main shows disabled exists in the runtime type but is a ... rtised in Discord capabilities, dropped by adaptation, and omitted from Discord mapping/link serialization.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix(discord): advertise disabled presentation support
PR branch already contained follow-up commit before automerge: fix(discord): preserve disabled link buttons
PR branch already contained follow-up commit before automerge: Preserve disabled Discord presentation buttons

The automerge loop is complete.

Automerge progress:

2026-05-19 21:27:40 UTC review passed f01328f7911f (structured ClawSweeper verdict: pass (sha=f01328f7911f7ff318894ec70ef6919bd8937...)

2026-05-19 21:03:31 UTC repair queued f01328f7911f (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359

2026-05-19 21:20:31 UTC review queued f01328f7911f (queued)

2026-05-19 23:09:24 UTC repair started (running) in 0s Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359 automerge-openclaw-openclaw-84188

2026-05-19 23:09:40 UTC validation plan (passed) in 16s Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359 pnpm test extensions/discord/src/components.test.ts extensions/discord/src/outbound-adapter.test.ts extensions/discord/src/shared-interactive.test.ts; pnpm che...

2026-05-19 23:09:52 UTC Codex write preflight (passed) in 29s Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359 danger-full-access

2026-05-19 23:15:09 UTC Codex edit 1 9bb60d8cbf97 (complete) in 5m 46s Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359 exit 0

2026-05-19 23:19:03 UTC validation and review 1 9bb60d8cbf97 (complete) in 9m 39s Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359 already-current

2026-05-19 23:19:07 UTC repair completed 9bb60d8cbf97 (branch updated) in 9m 43s Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359 initial automerge rebase is delegated to Codex repair

2026-05-19 23:19:06 UTC review queued 9bb60d8cbf97 (after repair)

2026-05-19 23:29:09 UTC automerge wait 9bb60d8cbf97 (waiting) in 19m 46s Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359 waiting for exact-head ClawSweeper review pass

2026-05-19 23:22:11 UTC review queued 9bb60d8cbf97 (queued)

2026-05-19 23:29:10 UTC repair finished 9bb60d8cbf97 (pushed) in 19m 47s Run: https://github.com/openclaw/clawsweeper/actions/runs/26125193359 repair_contributor_branch

2026-05-19 23:29:32 UTC review passed 9bb60d8cbf97 (structured ClawSweeper verdict: pass (sha=9bb60d8cbf97064a271cd542e42d3be41ac50...)

2026-05-19 23:29:51 UTC merged 9bb60d8cbf97 (merged by ClawSweeper automerge)

clawsweeper · 2026-05-19T23:29:33Z

ClawSweeper PR egg

✨ Hatched: 🥚 common Moonlit Test Hopper

       /\  .---.  /\         
      /  \/     \/  \        
     /   ( -   - )   \       
    |       ._.       |      
    |   /|  ===  |\   |      
     \  \|______/|/  /       
      '._  `--'  _.'         
         '-.__.-'            
       _/|_|  |_|\_          
      /__|      |__\         
       .-----------.         
      '-------------'

Rarity: 🥚 common.
Trait: keeps receipts.
Image traits: location workflow harbor; accessory green check lantern; palette amber, ink, and glacier blue; mood bright-eyed; pose curling around a status light; shell translucent glimmer shell; lighting bright celebratory glints; background delicate sparkle particles.
How to hatch it: once this PR reaches status: 👀 ready for maintainer look or status: 🚀 automerge armed, the PR author or a maintainer can comment @clawsweeper hatch to turn this ASCII egg into its generated creature image.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Moonlit Test Hopper in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
Hatchable usually means sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Summary: - Adds `disabled` to the message presentation button schema, advertises Discord disabled-button support, prese ... through Discord component mapping and link serialization, and adds regression tests plus a changelog entry. - Reproducibility: yes. Source inspection on current main shows `disabled` exists in the runtime type but is a ... rtised in Discord capabilities, dropped by adaptation, and omitted from Discord mapping/link serialization. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(discord): advertise disabled presentation support - PR branch already contained follow-up commit before automerge: fix(discord): preserve disabled link buttons - PR branch already contained follow-up commit before automerge: Preserve disabled Discord presentation buttons Validation: - ClawSweeper review passed for head 9bb60d8cbf97064a271cd542e42d3be41ac50061. - Required merge gates passed before the squash merge. Prepared head SHA: 9bb60d8cbf97064a271cd542e42d3be41ac50061 Review: openclaw/openclaw#84312 (comment) Co-authored-by: OpenClaw Contributor <100menotu001@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

Summary: - Adds `disabled` to the message presentation button schema, advertises Discord disabled-button support, prese ... through Discord component mapping and link serialization, and adds regression tests plus a changelog entry. - Reproducibility: yes. Source inspection on current main shows `disabled` exists in the runtime type but is a ... rtised in Discord capabilities, dropped by adaptation, and omitted from Discord mapping/link serialization. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(discord): advertise disabled presentation support - PR branch already contained follow-up commit before automerge: fix(discord): preserve disabled link buttons - PR branch already contained follow-up commit before automerge: Preserve disabled Discord presentation buttons Validation: - ClawSweeper review passed for head 9bb60d8. - Required merge gates passed before the squash merge. Prepared head SHA: 9bb60d8 Review: openclaw#84312 (comment) Co-authored-by: OpenClaw Contributor <100menotu001@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

clawsweeper Bot mentioned this pull request May 19, 2026

Preserve disabled Discord presentation buttons #84188

Closed

1 task

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 19, 2026

clawsweeper Bot added status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. and removed status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 19, 2026

100menotu001 and others added 4 commits May 19, 2026 23:10

fix(discord): preserve disabled presentation buttons

db42c49

fix(discord): advertise disabled presentation support

4b15734

fix(discord): preserve disabled link buttons

6ae1398

Preserve disabled Discord presentation buttons

9bb60d8

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-84188 branch from f01328f to 9bb60d8 Compare May 19, 2026 23:19

clawsweeper Bot merged commit 97aa0c8 into main May 19, 2026
98 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-84188 branch May 19, 2026 23:29

github-actions Bot mentioned this pull request May 20, 2026

📡 Upstream Digest — 2026-05-20 02:34 UTC curtismercier/openclaw-mods#901

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Preserve disabled Discord presentation buttons#84312

Preserve disabled Discord presentation buttons#84312
clawsweeper[bot] merged 4 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-84188

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 19, 2026 •

edited

Loading

clawsweeper Bot commented May 19, 2026 •

edited

Loading