fix(cron): use structured denial signals by clawsweeper[bot] · Pull Request #84311 · openclaw/openclaw

clawsweeper · 2026-05-19T20:51:31Z

Makes #84067 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-84067
Source PRs: fix(cron): use structured denial signals #84067
Credit: Source PR: fix(cron): use structured denial signals #84067
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Co-author credit kept:

@abnershang: Co-authored-by: Abner Shang 75654486+abnershang@users.noreply.github.com

fish notes: model gpt-5.5, reasoning high; reviewed against c76769b.

clawsweeper · 2026-05-19T20:52:43Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The PR changes isolated cron denial handling to use structured embedded tool-error metadata, preserves node-host denial wrappers, and updates cron docs, changelog, and focused regression tests.

Reproducibility: yes. for source-level reproduction: current main scans cron summary, output, synthesized text, and payload prose for denial tokens and promotes matches into fatal cron state. I did not execute tests in this read-only review.

PR rating
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster
Patch quality: 🐚 platinum hermit
Summary: Good focused patch with strong terminal proof and no blocking findings, with compatibility and delivery semantics left as the main maintainer decision.

Rank-up moves:

Let exact-head required checks finish before merge if they are still pending.
Confirm maintainers accept structured-only denials as the upgrade behavior.

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Sufficient (terminal): The source PR provides terminal proof for the thrown gateway/node-host denial path, and the replacement PR comment reports focused validation on the latest replacement head.

Risk before merge

Existing cron setups that depended on denial-looking assistant text being converted into a fatal cron error will now record that text as ordinary output unless structured metadata is present.
Cron run-history and outbound failure-notification semantics can change from failure delivery to normal output for prose-only denial-looking text.
Because the latest replacement-head repair was pushed after the previous durable review comment, final merge should still wait for exact-head CI/automerge gates and maintainer acceptance of the compatibility shift.

Maintainer options:

Land structured-only contract after gates (recommended)
Accept the intentional behavior change once exact-head required checks are green because the implementation, tests, docs, and supplied terminal proof align on structured metadata as the denial source.
Add explicit compatibility fallback
If maintainers need old prose-token behavior for existing operators, add a documented compatibility mode with tests for both structured-only and fallback behavior before merge.
Pause for product direction
If prose-only denial-looking assistant text must remain fatal by default, pause this PR and settle the cron contract before merging.

Next step before merge
No ClawSweeper repair job is indicated; the remaining action is exact-head CI/automerge gating plus maintainer acceptance of the documented compatibility shift.

Security
Cleared: The diff changes cron and embedded-agent error handling, tests, docs, and changelog only; I found no new dependency, workflow, secret, install, or supply-chain surface.

Review details

Best possible solution:

Land the structured-only cron denial contract after exact-head checks finish green, keeping the regression tests and docs as the compatibility record.

Do we have a high-confidence way to reproduce the issue?

Yes for source-level reproduction: current main scans cron summary, output, synthesized text, and payload prose for denial tokens and promotes matches into fatal cron state. I did not execute tests in this read-only review.

Is this the best way to solve the issue?

Yes, with an upgrade-policy caveat. Moving denial classification to structured tool-error metadata is the maintainable fix; preserving prose fallback would need an explicit compatibility mode and maintainer approval.

Label justifications:

P2: This is a normal-priority cron behavior fix with focused code surface but user-visible run-history and delivery semantics.
merge-risk: 🚨 compatibility: The PR removes the current prose-token fallback, so existing cron behavior can change on upgrade.
merge-risk: 🚨 message-delivery: The same cron output can move from failure notification/error history to ordinary output when no structured denial code is present.
rating: 🐚 platinum hermit: Current PR rating is 🐚 platinum hermit because proof is 🦞 diamond lobster, patch quality is 🐚 platinum hermit, and Good focused patch with strong terminal proof and no blocking findings, with compatibility and delivery semantics left as the main maintainer decision.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (terminal): The source PR provides terminal proof for the thrown gateway/node-host denial path, and the replacement PR comment reports focused validation on the latest replacement head.
proof: sufficient: Contributor real behavior proof is sufficient. The source PR provides terminal proof for the thrown gateway/node-host denial path, and the replacement PR comment reports focused validation on the latest replacement head.

What I checked:

current-main prose fallback: Current main scans cron summary/output/synthesized text and every payload text for denial tokens, then includes that prose-derived denial signal in hasFatalErrorPayload and embeddedRunError. (src/cron/isolated-agent/helpers.ts:44, 4408e60c3190)
structured-only failure signal: The PR changes resolveEmbeddedRunFailureSignal to accept only lastToolError.errorCode values matching SYSTEM_RUN_DENIED or INVALID_REQUEST, with the message used only as display text. (src/agents/pi-embedded-runner/failure-signal.ts:29, 047622fe8dc3)
tool lifecycle code propagation: The PR extracts structured denial codes from details.error, details.nodeError, and gateway wrapper fields, and records that code on lastToolError for the embedded runner. (src/agents/pi-embedded-subscribe.tools.ts:108, 047622fe8dc3)
cron outcome update: The PR removes the prose-derived denialSignal from cron outcome resolution, so fatal cron errors now come from structured error payloads, structured failure signals, or run-level errors. (src/cron/isolated-agent/helpers.ts:267, 047622fe8dc3)
regression coverage: The PR tests both sides of the contract: prose-only denial-looking output is not promoted, while typed failure signals still produce fatal cron failures. (src/cron/isolated-agent.helpers.test.ts:286, 047622fe8dc3)
docs contract: The CLI cron docs now state that structured execution-denial metadata is authoritative and final-output prose is not classified as denial unless structured metadata is present. Public docs: docs/cli/cron.md. (docs/cli/cron.md:168, 047622fe8dc3)

Likely related people:

@obviyus: Recent history in the available checkout attributes the current cron helper surface and several adjacent cron/agent fixes to Ayaan Zaidi, including cron delivery and NO_REPLY behavior. (role: recent cron and agent area contributor; confidence: high; commits: 6ee60fcfe228, 13a0d7a9e035, 49ae60d6cae1; files: src/cron/isolated-agent/helpers.ts, src/cron/isolated-agent.helpers.test.ts, src/agents/pi-embedded-runner/failure-signal.ts)
Eva: Recent embedded-agent commits cover replay, liveness, compaction, and related lifecycle behavior near the tool-error and embedded-runner surfaces touched here. (role: recent embedded-agent lifecycle contributor; confidence: medium; commits: a059309a9f9a, b9a9472cfd67, aa5bec4bdf40; files: src/agents/pi-embedded-subscribe.ts, src/agents/pi-embedded-subscribe.tools.ts, src/agents/pi-embedded-runner/run.ts)
@steipete: Broad source history in the available checkout shows the largest volume of changes across src/agents and src/cron, making this a reasonable escalation route if the narrower area owners are unavailable. (role: adjacent owner; confidence: low; files: src/agents, src/cron)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 4408e60c3190.

clawsweeper · 2026-05-19T20:59:06Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=047622fe8dc30fe779ac084edde210f1a16366e0)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-20T00:49:49Z
Merge commit: 7f8141ead974

What merged:

The PR changes isolated cron denial handling to use structured embedded tool-error metadata, preserves node-host denial wrappers, and updates cron docs, changelog, and focused regression tests.
Reproducibility: yes. for source-level reproduction: current main scans cron summary, output, synthesized te ... denial tokens and promotes matches into fatal cron state. I did not execute tests in this read-only review.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix(cron): normalize node denial wrappers
PR branch already contained follow-up commit before automerge: fix(cron): use structured denial signals
PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8406…

The automerge loop is complete.

Automerge progress:

2026-05-20 00:12:40 UTC validation and review 1 49d01262b40e (complete) in 7m 46s Run: https://github.com/openclaw/clawsweeper/actions/runs/26132668928 already-current

2026-05-20 00:13:17 UTC repair finished 49d01262b40e (opened) in 8m 23s Run: https://github.com/openclaw/clawsweeper/actions/runs/26132668928 open_fix_pr

2026-05-20 00:19:10 UTC review passed 49d01262b40e (structured ClawSweeper verdict: pass (sha=49d01262b40edba7b46ecc4d8b339e19f2a21...)

2026-05-20 00:19:34 UTC repair queued 49d01262b40e (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370

2026-05-20 00:19:05 UTC review queued 49d01262b40e (queued)

2026-05-20 00:26:32 UTC repair started (running) in 1s Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370 automerge-openclaw-openclaw-84067

2026-05-20 00:26:49 UTC validation plan (passed) in 17s Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370 pnpm test src/agents/pi-embedded-runner/failure-signal.test.ts src/agents/pi-embedded-subscribe.tools.test.ts src/agents/pi-embedded-subscribe.handlers.tools.t...

2026-05-20 00:27:01 UTC Codex write preflight (passed) in 29s Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370 danger-full-access

2026-05-20 00:35:21 UTC Codex edit 1 3911cdbd0eac (complete) in 8m 50s Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370 exit 0

2026-05-20 00:39:32 UTC validation and review 1 047622fe8dc3 (base moved) in 13m Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370 rebased

2026-05-20 00:39:37 UTC repair completed 047622fe8dc3 (branch updated) in 13m 6s Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370 initial automerge rebase is delegated to Codex repair

2026-05-20 00:39:37 UTC review queued 047622fe8dc3 (after repair)

2026-05-20 00:49:41 UTC automerge wait 047622fe8dc3 (waiting) in 23m 9s Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370 waiting for exact-head ClawSweeper review pass

2026-05-20 00:49:42 UTC repair finished 047622fe8dc3 (pushed) in 23m 11s Run: https://github.com/openclaw/clawsweeper/actions/runs/26133387370 repair_contributor_branch

2026-05-20 00:49:39 UTC review passed 047622fe8dc3 (structured ClawSweeper verdict: pass (sha=047622fe8dc30fe779ac084edde210f1a1636...)

2026-05-20 00:49:51 UTC merged 047622fe8dc3 (merged by ClawSweeper automerge)

clawsweeper · 2026-05-19T23:29:42Z

ClawSweeper PR egg

✨ Hatched: 🥚 common Tiny Clawlet

        .--^^^^--.           
     .-'  o    o  '-.        
    /       \__/      \      
   |    /\  ____  /\   |     
   |   /  \/____\/  \  |     
    \  \_.------._/  /       
     '._  `----'  _.'        
        '-.____.-'           
       _/|_|  |_|\_          
      /__|      |__\         
       .-----------.         
      '-------------'

Rarity: 🥚 common.
Trait: stacks clean commits.
Image traits: location flaky test forest; accessory little merge flag; palette rose quartz and slate; mood patient; pose standing beside its cracked shell; shell woven fiber shell; lighting soft underwater shimmer; background quiet workflow signs.
How to hatch it: once this PR reaches status: 👀 ready for maintainer look or status: 🚀 automerge armed, the PR author or a maintainer can comment @clawsweeper hatch to turn this ASCII egg into its generated creature image.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Tiny Clawlet in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
Hatchable usually means sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Co-authored-by: Abner Shang <75654486+abnershang@users.noreply.github.com>

…7 (1)

Summary: - The PR changes isolated cron denial handling to use structured embedded tool-error metadata, preserves node-host denial wrappers, and updates cron docs, changelog, and focused regression tests. - Reproducibility: yes. for source-level reproduction: current main scans cron summary, output, synthesized te ... denial tokens and promotes matches into fatal cron state. I did not execute tests in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(cron): normalize node denial wrappers - PR branch already contained follow-up commit before automerge: fix(cron): use structured denial signals - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8406… Validation: - ClawSweeper review passed for head 047622fe8dc30fe779ac084edde210f1a16366e0. - Required merge gates passed before the squash merge. Prepared head SHA: 047622fe8dc30fe779ac084edde210f1a16366e0 Review: openclaw/openclaw#84311 (comment) Co-authored-by: abnershang <abner.shang@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: Abner Shang <75654486+abnershang@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

Summary: - The PR changes isolated cron denial handling to use structured embedded tool-error metadata, preserves node-host denial wrappers, and updates cron docs, changelog, and focused regression tests. - Reproducibility: yes. for source-level reproduction: current main scans cron summary, output, synthesized te ... denial tokens and promotes matches into fatal cron state. I did not execute tests in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(cron): normalize node denial wrappers - PR branch already contained follow-up commit before automerge: fix(cron): use structured denial signals - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8406… Validation: - ClawSweeper review passed for head 047622f. - Required merge gates passed before the squash merge. Prepared head SHA: 047622f Review: openclaw#84311 (comment) Co-authored-by: abnershang <abner.shang@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: Abner Shang <75654486+abnershang@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

clawsweeper Bot mentioned this pull request May 19, 2026

fix(cron): use structured denial signals #84067

Closed

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 19, 2026

clawsweeper Bot added status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. and removed status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 19, 2026

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-84067 branch from c76769b to 2620574 Compare May 19, 2026 23:23

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-84067 branch from 2620574 to 49d0126 Compare May 20, 2026 00:12

clawsweeper Bot added proof: supplied External PR includes structured after-fix real behavior proof. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 20, 2026

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 20, 2026

clawsweeper Bot removed the status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. label May 20, 2026

abnershang and others added 4 commits May 20, 2026 00:39

fix(cron): use structured denial signals

2b66326

fix(cron): normalize node denial wrappers

ee399bb

fix(cron): use structured denial signals

081eab9

Co-authored-by: Abner Shang <75654486+abnershang@users.noreply.github.com>

fix(clawsweeper): address review for automerge-openclaw-openclaw-8406…

047622f

…7 (1)

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-84067 branch from 49d0126 to 047622f Compare May 20, 2026 00:39

clawsweeper Bot merged commit 7f8141e into main May 20, 2026
99 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-84067 branch May 20, 2026 00:49

Haderach-Ram mentioned this pull request May 20, 2026

Ecosystem Digest — 2026-05-20 Haderach-Ram/openclaw-radar#13

Open

github-actions Bot mentioned this pull request May 20, 2026

📡 Upstream Digest — 2026-05-20 02:34 UTC curtismercier/openclaw-mods#901

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cron): use structured denial signals#84311

fix(cron): use structured denial signals#84311
clawsweeper[bot] merged 4 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-84067

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 19, 2026 •

edited

Loading

clawsweeper Bot commented May 19, 2026 •

edited

Loading

clawsweeper Bot commented May 19, 2026 •

edited

Loading