fix(twitch): export clearRegistryForTest for cross-test isolation (#83887) by clawsweeper[bot] · Pull Request #84309 · openclaw/openclaw

clawsweeper · 2026-05-19T20:49:15Z

Makes #84244 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-84244
Source PRs: fix(twitch): export clearRegistryForTest for cross-test isolation (#83887) #84244
Credit: Source PR: fix(twitch): export clearRegistryForTest for cross-test isolation (#83887) #84244
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Inherited issue-closing references from the source PR:
Fixes #83887

Co-author credit kept:

@hclsys: Co-authored-by: hcl 7755017+hclsys@users.noreply.github.com

fish notes: model gpt-5.5, reasoning high; reviewed against 0dbda6b.

clawsweeper · 2026-05-19T20:50:34Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The PR adds an async test-only Twitch client-manager registry reset helper, a focused registry isolation test, and an Unreleased changelog entry.

Reproducibility: yes. Source inspection shows getOrCreateClientManager() returns the cached module-level manager for the same account id, and the repo’s Vitest configuration is explicitly non-isolated.

PR rating
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🐚 platinum hermit
Summary: Good normal PR quality: focused implementation, sufficient terminal proof, and no blocking review findings.

Rank-up moves:

none

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Sufficient (terminal): The linked source PR includes terminal proof from a Node 22 probe showing stale-manager behavior before clearing and fresh-manager behavior after using the helper.

Risk before merge

No test command was run in this read-only review; the final merge should still wait for exact-head changed checks in the automerge lane.

Maintainer options:

Decide the mitigation before merge
Land the narrow registry helper and regression test through the existing automerge path once exact-head checks pass, then close Module-level registry has no test-clearable export, risking cross-test pollution under --isolate=false #83887 as fixed.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge
No repair job is needed because the PR has no blocking findings and is already in the automerge lane.

Security
Cleared: The diff is limited to a Twitch test helper, a colocated Vitest test, and changelog text; it does not touch dependencies, workflows, secrets, permissions, packaging, or runtime install paths.

Review details

Best possible solution:

Land the narrow registry helper and regression test through the existing automerge path once exact-head checks pass, then close #83887 as fixed.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows getOrCreateClientManager() returns the cached module-level manager for the same account id, and the repo’s Vitest configuration is explicitly non-isolated.

Is this the best way to solve the issue?

Yes. A test-only registry clear helper mirrors the existing TwitchClientManager.clearForTest() pattern and avoids changing production cache semantics.

Label changes:

remove status: 👀 ready for maintainer look: Current PR status label is status: 🚀 automerge armed.

Label justifications:

P3: This is a low-risk Twitch test-isolation fix with no intended production behavior change.
rating: 🐚 platinum hermit: Current PR rating is 🐚 platinum hermit because proof is 🐚 platinum hermit, patch quality is 🐚 platinum hermit, and Good normal PR quality: focused implementation, sufficient terminal proof, and no blocking review findings.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (terminal): The linked source PR includes terminal proof from a Node 22 probe showing stale-manager behavior before clearing and fresh-manager behavior after using the helper.
proof: sufficient: Contributor real behavior proof is sufficient. The linked source PR includes terminal proof from a Node 22 probe showing stale-manager behavior before clearing and fresh-manager behavior after using the helper.

What I checked:

Current main still has module-level registry state: Current main keeps Twitch client managers in a module-level Map and returns a cached manager by account id before considering the new logger, which matches the reported cross-test pollution path. (extensions/twitch/src/client-manager-registry.ts:29, 00da318350e2)
PR adds the reset helper at the right boundary: The PR head adds clearRegistryForTest() in the same registry module, disconnecting cached managers before clearing the Map and documenting it as test-only. (extensions/twitch/src/client-manager-registry.ts:102, 38c3fadc9163)
PR includes focused regression coverage: The new test proves cache reuse before clearing, verifies disconnectAll() is called during cleanup, and confirms a fresh manager is created after clearing. (extensions/twitch/src/client-manager-registry.test.ts:23, 38c3fadc9163)
Test runner contract supports the issue premise: The repository test docs state the base Vitest config defaults to threads with isolate:false, so module-level test state needs explicit cleanup. Public docs: docs/reference/test.md. (docs/reference/test.md:29, 00da318350e2)
Feature history: The registry and sibling TwitchClientManager.clearForTest() pattern both trace to the same current-main introduction commit for the Twitch client surface. (extensions/twitch/src/client-manager-registry.ts:1, ddeaebfc6807)
Merge shape check: The PR diff relative to its merge base touches only CHANGELOG.md and the Twitch registry/test files; git diff --check reported no whitespace errors. (38c3fadc9163)

Likely related people:

galiniliev: The current Twitch registry, TwitchClientManager, and existing clearForTest test-helper pattern were introduced together in ddeaebf. (role: introduced behavior; confidence: high; commits: ddeaebfc6807; files: extensions/twitch/src/client-manager-registry.ts, extensions/twitch/src/twitch-client.ts, extensions/twitch/src/twitch-client.test.ts)
TurboTheTurtle: Recent merged Twitch client work changed TwitchClientManager and its tests, making this person a useful adjacent routing candidate for the same client-manager surface. (role: recent adjacent contributor; confidence: medium; commits: 3bc728eaa993; files: extensions/twitch/src/twitch-client.ts, extensions/twitch/src/twitch-client.test.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 00da318350e2.

clawsweeper · 2026-05-19T20:55:43Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=38c3fadc91636aeaff0e37397608512d8d713703)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-20T00:26:22Z
Merge commit: ff5354ee4fbd

What merged:

The PR adds an async test-only Twitch client-manager registry reset helper, a focused registry isolation test, and an Unreleased changelog entry.
Reproducibility: yes. Source inspection shows getOrCreateClientManager() returns the cached module-level manager for the same account id, and the repo’s Vitest configuration is explicitly non-isolated.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix(twitch): export clearRegistryForTest for cross-test isolation (Track and persist Claude's returned session ID for conversation continuity #8…

The automerge loop is complete.

Automerge progress:

2026-05-19 23:22:55 UTC repair completed fb964fc6f57e (branch updated) in 11m 12s Run: https://github.com/openclaw/clawsweeper/actions/runs/26124782401 initial automerge rebase is delegated to Codex repair

2026-05-19 23:22:55 UTC review queued fb964fc6f57e (after repair)

2026-05-19 23:32:58 UTC automerge wait fb964fc6f57e (waiting) in 21m 15s Run: https://github.com/openclaw/clawsweeper/actions/runs/26124782401 mergeable state is CONFLICTING

2026-05-19 23:55:57 UTC review passed fb964fc6f57e (structured ClawSweeper verdict: pass (sha=fb964fc6f57e086811c3c400fd1c0b7e1c664...)

2026-05-19 23:32:59 UTC repair finished fb964fc6f57e (pushed) in 21m 16s Run: https://github.com/openclaw/clawsweeper/actions/runs/26124782401 repair_contributor_branch

2026-05-19 23:50:20 UTC review queued fb964fc6f57e (queued)

2026-05-19 23:56:14 UTC repair queued fb964fc6f57e (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26132582217

2026-05-20 00:01:18 UTC repair started (running) in 1s Run: https://github.com/openclaw/clawsweeper/actions/runs/26132582217 automerge-openclaw-openclaw-84244

2026-05-20 00:01:34 UTC validation plan (passed) in 17s Run: https://github.com/openclaw/clawsweeper/actions/runs/26132582217 pnpm check:changed; pnpm lint; pnpm check:test-types

2026-05-20 00:01:46 UTC Codex write preflight (passed) in 28s Run: https://github.com/openclaw/clawsweeper/actions/runs/26132582217 danger-full-access

2026-05-20 00:16:57 UTC Codex edit 1 13c587d01df4 (complete) in 15m 40s Run: https://github.com/openclaw/clawsweeper/actions/runs/26132582217 exit 0

2026-05-20 00:20:09 UTC validation and review 1 38c3fadc9163 (base moved) in 18m 51s Run: https://github.com/openclaw/clawsweeper/actions/runs/26132582217 rebased

2026-05-20 00:20:12 UTC review queued d91985b0cb93 (queued)

2026-05-20 00:20:37 UTC repair finished 38c3fadc9163 (opened) in 19m 20s Run: https://github.com/openclaw/clawsweeper/actions/runs/26132582217 open_fix_pr

2026-05-20 00:26:09 UTC review passed 38c3fadc9163 (structured ClawSweeper verdict: pass (sha=38c3fadc91636aeaff0e37397608512d8d713...)

2026-05-20 00:26:24 UTC merged 38c3fadc9163 (merged by ClawSweeper automerge)

clawsweeper · 2026-05-19T23:28:53Z

ClawSweeper PR egg

✨ Hatched: 🌱 uncommon Brave Diff Drake

        .--^^^^--.           
     .-'  o    o  '-.        
    /       \__/      \      
   |    /\  ____  /\   |     
   |   /  \/____\/  \  |     
    \  \_.------._/  /       
     '._  `----'  _.'        
        '-.____.-'           
       _/|_|  |_|\_          
      /__|      |__\         
       .-----------.         
      '-------------'

Rarity: 🌱 uncommon.
Trait: hums during re-review.
Image traits: location status garden; accessory CI status badge; palette pearl, teal, and neon green; mood celebratory; pose pointing at a small proof artifact; shell paper lantern shell; lighting subtle sparkle highlights; background smooth stones and checkmarks.
How to hatch it: once this PR reaches status: 👀 ready for maintainer look or status: 🚀 automerge armed, the PR author or a maintainer can comment @clawsweeper hatch to turn this ASCII egg into its generated creature image.
Share on X: post this hatch
Copy: My PR egg hatched a 🌱 uncommon Brave Diff Drake in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
Hatchable usually means sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

…3887) `client-manager-registry.ts` holds a module-level `Map<accountId, RegistryEntry>` for `getOrCreateClientManager`. `TwitchClientManager` in the sibling module already acknowledges that module-level state needs a test escape hatch (`clearForTest`), but the registry lacks the equivalent. Under vitest `--isolate=false` (or any harness that keeps the module graph hot across tests) a test that calls `getOrCreateClientManager('default', loggerA)` leaves its entry behind, and the next test calling the same factory silently gets loggerA's manager — chasing a phantom mock-assertion bug becomes the failure mode. Add an exported `clearRegistryForTest()` that calls `registry.clear()`, mirroring `TwitchClientManager.clearForTest`. No production behavior change — production code never calls this.

…3887)

…3887) Co-authored-by: hcl <7755017+hclsys@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>

…3887) (#84309) Summary: - The PR adds an async test-only Twitch client-manager registry reset helper, a focused registry isolation test, and an Unreleased changelog entry. - Reproducibility: yes. Source inspection shows getOrCreateClientManager() returns the cached module-level manager for the same account id, and the repo’s Vitest configuration is explicitly non-isolated. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(twitch): export clearRegistryForTest for cross-test isolation (#8… Validation: - ClawSweeper review passed for head 38c3fadc91636aeaff0e37397608512d8d713703. - Required merge gates passed before the squash merge. Prepared head SHA: 38c3fadc91636aeaff0e37397608512d8d713703 Review: openclaw/openclaw#84309 (comment) Co-authored-by: HCL <chenglunhu@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

…enclaw#83887) (openclaw#84309) Summary: - The PR adds an async test-only Twitch client-manager registry reset helper, a focused registry isolation test, and an Unreleased changelog entry. - Reproducibility: yes. Source inspection shows getOrCreateClientManager() returns the cached module-level manager for the same account id, and the repo’s Vitest configuration is explicitly non-isolated. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(twitch): export clearRegistryForTest for cross-test isolation (openclaw#8… Validation: - ClawSweeper review passed for head 38c3fad. - Required merge gates passed before the squash merge. Prepared head SHA: 38c3fad Review: openclaw#84309 (comment) Co-authored-by: HCL <chenglunhu@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

clawsweeper Bot mentioned this pull request May 19, 2026

fix(twitch): export clearRegistryForTest for cross-test isolation (#83887) #84244

Closed

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 19, 2026

clawsweeper Bot added status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. and removed status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 19, 2026

clawsweeper Bot added the P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. label May 19, 2026

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-84244 branch from 0dbda6b to fb964fc Compare May 19, 2026 23:22

openclaw-barnacle Bot added size: S and removed size: XS labels May 19, 2026

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-84244 branch from fb964fc to d91985b Compare May 20, 2026 00:17

HCL and others added 4 commits May 20, 2026 00:20

fix(twitch): export clearRegistryForTest for cross-test isolation (#8…

f3b7479

…3887)

fix(twitch): export clearRegistryForTest for cross-test isolation (#8…

6f7cf7d

…3887)

fix(twitch): export clearRegistryForTest for cross-test isolation (#8…

38c3fad

…3887) Co-authored-by: hcl <7755017+hclsys@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-84244 branch from d91985b to 38c3fad Compare May 20, 2026 00:20

clawsweeper Bot added size: XS proof: supplied External PR includes structured after-fix real behavior proof. labels May 20, 2026

openclaw-barnacle Bot removed the size: XS label May 20, 2026

clawsweeper Bot added the status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. label May 20, 2026

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 20, 2026

clawsweeper Bot removed the status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. label May 20, 2026

clawsweeper Bot merged commit ff5354e into main May 20, 2026
120 of 123 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-84244 branch May 20, 2026 00:26

Haderach-Ram mentioned this pull request May 20, 2026

Ecosystem Digest — 2026-05-20 Haderach-Ram/openclaw-radar#13

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(twitch): export clearRegistryForTest for cross-test isolation (#83887)#84309

fix(twitch): export clearRegistryForTest for cross-test isolation (#83887)#84309
clawsweeper[bot] merged 4 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-84244

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 19, 2026 •

edited

Loading

clawsweeper Bot commented May 19, 2026 •

edited

Loading

clawsweeper Bot commented May 19, 2026 •

edited

Loading