fix(cli): preserve equals in root option values [AI-assisted] by clawsweeper[bot] · Pull Request #84107 · openclaw/openclaw

clawsweeper · 2026-05-19T11:32:26Z

Makes #83995 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-83995
Source PRs: fix(cli): preserve equals in root option values [AI-assisted] #83995
Credit: Source PR: fix(cli): preserve equals in root option values [AI-assisted] #83995
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Inherited issue-closing references from the source PR:
Closes #83882

Co-author credit kept:

@ThiagoCAltoe: Co-authored-by: Thiago Costa 71539514+ThiagoCAltoe@users.noreply.github.com

fish notes: model gpt-5.5, reasoning high; reviewed against 8a15801.

clawsweeper · 2026-05-19T11:33:46Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
This PR updates CLI root option parsing to preserve embedded equals signs, adds focused Vitest coverage for inline and space-separated values, and records the fix in the changelog.

Reproducibility: yes. by source inspection: current main uses raw.split("=", 2), so --token=abc=def returns only abc; the PR body also supplies after-fix live output for the same path.

PR rating
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Summary: This is a small, well-scoped bug fix with focused coverage and sufficient real behavior proof.

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

PR egg
✨ Hatched: 🥚 common Brave Clawlet

        /\     /\            
      _/  \___/  \_          
     /  ( o   o )  \         
    |      \_/      |        
    |   /\  ===  /\ |        
     \_/  \_____/  \_/       
        _/|_| |_|\_          
       /__| | | |__\         
          ' ' ' '            
         /_/     \_\         
       .-----------.         
      '-------------'

Rarity: 🥚 common.
Trait: polishes edge cases.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Brave Clawlet in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
How to hatch it: reach status: 👀 ready for maintainer look or status: 🚀 automerge armed; that usually means sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Real behavior proof
Sufficient (live_output): The inherited source PR body contains copied live terminal output from a real Linux Node checkout showing the changed parser preserving embedded equals signs after the patch.

Next step before merge
No repair lane is needed because the automerge-opted replacement PR has no blocking findings and already contains the narrow code/test/changelog changes.

Security
Cleared: The diff only changes local CLI argument parsing, adds a focused test, and updates the changelog; it does not add dependencies, permissions, network access, or new code execution paths.

Review details

Best possible solution:

Land the narrow parser fix with its regression test so inline root option values treat only the first = as the separator.

Do we have a high-confidence way to reproduce the issue?

Yes, by source inspection: current main uses raw.split("=", 2), so --token=abc=def returns only abc; the PR body also supplies after-fix live output for the same path.

Is this the best way to solve the issue?

Yes, slicing after the first = is the narrowest maintainable fix because inline parsing only needs the first separator and the tests preserve existing empty and space-separated behavior.

Label justifications:

P2: This is a normal-priority CLI bug fix for corrupted inline option values with a small, well-contained surface.

Acceptance criteria:

OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs run --config test/vitest/vitest.cli.config.ts src/cli/root-option-value.test.ts
git diff --check
pnpm check:changed

What I checked:

PR diff changes parser to preserve the full inline value: The branch replaces raw.split("=", 2) with raw.slice(raw.indexOf("=") + 1), which preserves all characters after the first separator while keeping the existing trim/null handling. (src/cli/root-option-value.ts:11, 8a15801e7994)
Regression test covers the reported edge cases: The new test asserts that --token=abc=def and --token=abc== preserve embedded equals signs, --token= remains missing, and space-separated values still consume the next token. (src/cli/root-option-value.test.ts:5, 8a15801e7994)
Current main still has the truncating parser: On current main, takeCliRootOptionValue still destructures raw.split("=", 2), so the PR is not redundant on main. (src/cli/root-option-value.ts:11, d7083bab4c6e)
Original helper history: src/cli/root-option-value.ts was introduced in commit f135f68438931e6fb8b071804e07050d7f988a6f as a CLI helper for root option parsing; that history ties the current bug to this helper rather than a later command-specific caller. (src/cli/root-option-value.ts:1, f135f6843893)
Real behavior proof supplied in source PR: The source PR body includes copied live terminal output from a Linux Node 22.21.1 checkout showing token, base64-padding, and URL-like inline values preserving embedded equals signs after the patch. (4486b7ec518c)

Likely related people:

Takhoffman: Recent CLI history and the automerge request both point to this account as connected to the CLI parsing area and this repair path. (role: recent area contributor; confidence: medium; commits: f135f6843893; files: src/cli/root-option-value.ts)
ThiagoCAltoe: Authored the source PR commit that this replacement PR preserves, including the parser fix and regression test. (role: source PR contributor; confidence: high; commits: a4bef79bfe08; files: src/cli/root-option-value.ts, src/cli/root-option-value.test.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against d7083bab4c6e.

clawsweeper · 2026-05-19T11:37:40Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=8a15801e7994b79bd7eac8697654da048ec63698)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-19T11:37:36Z
Merge commit: d916f176e194

What merged:

This PR updates CLI root option parsing to preserve embedded equals signs, adds focused Vitest coverage for inline and space-separated values, and records the fix in the changelog.
Reproducibility: yes. by source inspection: current main uses raw.split("=", 2), so --token=abc=def returns only abc; the PR body also supplies after-fix live output for the same path.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix(cli): preserve equals in root option values [AI-assisted]

The automerge loop is complete.

Automerge progress:

2026-05-19 11:36:12 UTC review passed 8a15801e7994 (structured ClawSweeper verdict: pass (sha=8a15801e7994b79bd7eac8697654da048ec63...)

2026-05-19 11:37:39 UTC merged 8a15801e7994 (merged by ClawSweeper automerge)

* feat(ui): tool name style in usage panel (openclaw#84310) Summary: - This PR adds scoped truncation and hover titles to usage-panel context-breakdown names and adds a changelog entry crediting the source PR. - Reproducibility: yes. at source/proof level: current main renders long context names without truncation or t ... he overflow before and ellipsis/tooltip after. I did not run a live browser session in this read-only pass. Automerge notes: - PR branch already contained follow-up commit before automerge: feat(ui): tool name style in usage panel Validation: - ClawSweeper review passed for head 396e405. - Required merge gates passed before the squash merge. Prepared head SHA: 396e405 Review: openclaw#84310 (comment) Co-authored-by: Rain120 <1085131904@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com> * fix(clawhub): preserve base URL path prefix [AI-assisted] (openclaw#83982) Summary: - The PR updates `src/infra/clawhub.ts` URL joining, adds a path-prefix regression test in `src/infra/clawhub.test.ts`, and adds a changelog bullet. - Reproducibility: yes. Source inspection plus a direct Node URL check show current main drops `/clawhub` when resolving a leading-slash API path against a prefixed base URL. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(clawhub): preserve base URL path prefix [AI-assisted] Validation: - ClawSweeper review passed for head 7bb2cb8. - Required merge gates passed before the squash merge. Prepared head SHA: 7bb2cb8 Review: openclaw#83982 (comment) Co-authored-by: Thiago Costa <thiago12_fera@hotmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com> * fix(docker): keep codex plugin in release images Ported from upstream d0f7c8f. Adds OPENCLAW_EXTENSIONS=diagnostics-otel,codex to both amd64 and arm64 Docker release builds and adds regression test. * fix(cli): format acp client errors with formatErrorMessage (openclaw#83904) (openclaw#84080) Summary: - The PR changes `openclaw acp client` error handling to use `formatErrorMessage`, adds a plain-object rejection regression test, and adds a changelog entry. - Reproducibility: yes. Current main visibly sends `openclaw acp client` caught errors through `String(err)`, ... catch already uses `formatErrorMessage`; I did not run a live failing ACP server in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(cli): format acp client errors with formatErrorMessage (openclaw#83904) Validation: - ClawSweeper review passed for head 69ef0e7. - Required merge gates passed before the squash merge. Prepared head SHA: 69ef0e7 Review: openclaw#84080 (comment) Co-authored-by: HCL <chenglunhu@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com> * fix(cli): preserve first line of channels logs at window boundary (openclaw#84106) Summary: - The PR updates `openclaw channels logs` tail-window reading to keep a complete first line when the 1 MB window starts on a newline boundary, adds a regression test, and adds a changelog entry. - Reproducibility: yes. Source inspection on current main shows the unconditional first-line drop, and the PR ... s provide terminal before/after CLI output for a 2 MB log whose tail window starts exactly after a newline. Automerge notes: - PR branch already contained follow-up commit before automerge: Merge remote-tracking branch 'origin/main' into fix/channels-logs-dro… - PR branch already contained follow-up commit before automerge: fix(cli): preserve first line of channels logs at window boundary Validation: - ClawSweeper review passed for head 284b312. - Required merge gates passed before the squash merge. Prepared head SHA: 284b312 Review: openclaw#84106 (comment) Co-authored-by: BSG2000 <bsg2000@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com> * fix(cli): preserve equals in root option values [AI-assisted] (openclaw#84107) Summary: - This PR updates CLI root option parsing to preserve embedded equals signs, adds focused Vitest coverage for inline and space-separated values, and records the fix in the changelog. - Reproducibility: yes. by source inspection: current main uses `raw.split("=", 2)`, so `--token=abc=def` returns only `abc`; the PR body also supplies after-fix live output for the same path. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(cli): preserve equals in root option values [AI-assisted] Validation: - ClawSweeper review passed for head 8a15801. - Required merge gates passed before the squash merge. Prepared head SHA: 8a15801 Review: openclaw#84107 (comment) Co-authored-by: Thiago Costa <thiago12_fera@hotmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com> * fix(cli): reject out-of-range port numbers in parsePort (openclaw#83900) (openclaw#84008) Summary: - The PR adds a 65,535 upper-bound check to the shared CLI `parsePort` helper, a colocated regression test, and a changelog entry for the linked port-range bug. - Reproducibility: yes. Source inspection on current main shows `parsePort('99999')` delegates to `parseStrict ... sitive safe integer, so the return would be `99999`; I did not execute it because this review is read-only. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(cli): reject out-of-range port numbers in parsePort (openclaw#83900) Validation: - ClawSweeper review passed for head 9ad0705. - Required merge gates passed before the squash merge. Prepared head SHA: 9ad0705 Review: openclaw#84008 (comment) Co-authored-by: HCL <chenglunhu@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com> * fix(agents): ignore duplicate embedded run clears * fix(agents): ignore duplicate embedded run clears * test(agents): fix embedded run clear lint * docs(changelog): note embedded run clear fix --------- Co-authored-by: Galin Iliev <Galin.Iliev@microsoft.com> * fix(config): allow bundled provider timeout overlays (openclaw#83267) * fix config provider timeout overlays Allow bundled model provider config entries to act as overlays so fields like timeoutSeconds can be configured without redeclaring baseUrl and models. Keep unknown custom provider declarations strict, and guard configured-provider fallback against overlay entries without models. * fix(config): include provider aliases in model overlays * fix(config): guard Foundry timeout overlays * fix(config): normalize bundled provider overlays * fix(models): reject overlay-only fallback models * fix(whatsapp): clarify inbound group diagnostics (openclaw#83969) Summary: - The PR updates WhatsApp inbound listener and group-drop diagnostics, adds focused tests, and documents that observed but unregistered groups must be admitted through `channels.whatsapp.groups`. - Reproducibility: yes. from source inspection: current main still emits the DM-only startup log and vague gro ... sions/whatsapp/src/auto-reply/monitor.ts` and `extensions/whatsapp/src/auto-reply/monitor/group-gating.ts`. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(whatsapp): clarify group drop guidance - PR branch already contained follow-up commit before automerge: fix(whatsapp): make inbound diagnostics policy-aware - PR branch already contained follow-up commit before automerge: fix(whatsapp): clarify inbound group diagnostics Validation: - ClawSweeper review passed for head 0da24e3. - Required merge gates passed before the squash merge. Prepared head SHA: 0da24e3 Review: openclaw#83969 (comment) Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com> --------- Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: Rain120 <1085131904@qq.com> Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com> Co-authored-by: Thiago Costa <thiago12_fera@hotmail.com> Co-authored-by: hcl <chenglunhu@gmail.com> Co-authored-by: Thomas Krohnfuß <BSG2000@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Galin Iliev <iliev@galcho.com> Co-authored-by: Galin Iliev <Galin.Iliev@microsoft.com> Co-authored-by: Gio Della-Libera <giodl73@gmail.com> Co-authored-by: Neerav Makwana <261249544+neeravmakwana@users.noreply.github.com>

Summary: - This PR updates CLI root option parsing to preserve embedded equals signs, adds focused Vitest coverage for inline and space-separated values, and records the fix in the changelog. - Reproducibility: yes. by source inspection: current main uses `raw.split("=", 2)`, so `--token=abc=def` returns only `abc`; the PR body also supplies after-fix live output for the same path. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(cli): preserve equals in root option values [AI-assisted] Validation: - ClawSweeper review passed for head 8a15801e7994b79bd7eac8697654da048ec63698. - Required merge gates passed before the squash merge. Prepared head SHA: 8a15801e7994b79bd7eac8697654da048ec63698 Review: openclaw/openclaw#84107 (comment) Co-authored-by: Thiago Costa <thiago12_fera@hotmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

…aw#84107) Summary: - This PR updates CLI root option parsing to preserve embedded equals signs, adds focused Vitest coverage for inline and space-separated values, and records the fix in the changelog. - Reproducibility: yes. by source inspection: current main uses `raw.split("=", 2)`, so `--token=abc=def` returns only `abc`; the PR body also supplies after-fix live output for the same path. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(cli): preserve equals in root option values [AI-assisted] Validation: - ClawSweeper review passed for head 8a15801. - Required merge gates passed before the squash merge. Prepared head SHA: 8a15801 Review: openclaw#84107 (comment) Co-authored-by: Thiago Costa <thiago12_fera@hotmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

ThiagoCAltoe and others added 2 commits May 19, 2026 11:25

fix(cli): preserve equals in root option values

a4bef79

fix(cli): preserve equals in root option values [AI-assisted]

8a15801

clawsweeper Bot mentioned this pull request May 19, 2026

fix(cli): preserve equals in root option values [AI-assisted] #83995

Closed

25 tasks

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 19, 2026

clawsweeper Bot merged commit d916f17 into main May 19, 2026
181 of 198 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-83995 branch May 19, 2026 11:37

github-actions Bot mentioned this pull request May 19, 2026

📡 Upstream Digest — 2026-05-19 14:40 UTC curtismercier/openclaw-mods#897

Open

clawsweeper Bot mentioned this pull request May 20, 2026

No tests for takeCliRootOptionValue — key parsing logic unverified #83884

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cli): preserve equals in root option values [AI-assisted]#84107

fix(cli): preserve equals in root option values [AI-assisted]#84107
clawsweeper[bot] merged 2 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83995

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 19, 2026 •

edited

Loading