fix: retry config snapshot after rejection by clawsweeper[bot] · Pull Request #83944 · openclaw/openclaw

clawsweeper · 2026-05-19T03:03:44Z

Makes #83931 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-83931
Source PRs: fix: retry config snapshot after rejection #83931
Credit: Source PR: fix: retry config snapshot after rejection #83931
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Inherited issue-closing references from the source PR:
Closes #83855

Co-author credit kept:

@honor2030: Co-authored-by: 이민재 19909783+honor2030@users.noreply.github.com

fish notes: model gpt-5.5, reasoning high; reviewed against 7ebf582.

clawsweeper · 2026-05-19T03:04:51Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
This PR clears the cached CLI config snapshot promise when a read rejects, adds a reject-retry-cache regression test, and adds an Unreleased changelog entry.

Reproducibility: yes. Current main clearly caches the first snapshot-read promise, and the source PR supplied a focused reject, recover, cached-success probe; I did not rerun it in this read-only review.

PR rating
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Summary: Focused bug fix with strong terminal proof, targeted regression coverage, no review findings, and no security concerns.

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

PR egg
✨ Hatched: 🥚 common Pearl Review Wisp

        /\     /\            
      _/  \___/  \_          
     /  ( o   o )  \         
    |      \_/      |        
    |   /\  ===  /\ |        
     \_/  \_____/  \_/       
        _/|_| |_|\_          
       /__| | | |__\         
          ' ' ' '            
         /_/     \_\         
       .-----------.         
      '-------------'

Rarity: 🥚 common.
Trait: purrs at green checks.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Pearl Review Wisp in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
How to hatch it: reach status: 👀 ready for maintainer look or status: 🚀 automerge armed; that usually means sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Real behavior proof
Sufficient (terminal): The source PR provides terminal output for the focused Vitest file and a manual runtime probe showing first rejection, second recovery, and third cached success; this replacement branch preserves the code fix.

Risk before merge
Why this matters: - This read-only review did not rerun the focused Vitest file or changed checks locally; final merge should rely on exact-head CI or the existing ClawSweeper validation gate.

Maintainer options:

Decide the mitigation before merge
Merge the narrow retry-on-rejection fix with its regression coverage once exact-head checks and mergeability gates remain green.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge
No repair job is needed; the automerge-opted PR has no actionable review findings and should proceed through exact-head checks and mergeability gates.

Security
Cleared: The diff only changes CLI config snapshot memoization, one focused test, and changelog text; it does not add dependencies, permissions, workflow changes, secret handling, network calls, or new execution surfaces.

Review details

Best possible solution:

Merge the narrow retry-on-rejection fix with its regression coverage once exact-head checks and mergeability gates remain green.

Do we have a high-confidence way to reproduce the issue?

Yes. Current main clearly caches the first snapshot-read promise, and the source PR supplied a focused reject, recover, cached-success probe; I did not rerun it in this read-only review.

Is this the best way to solve the issue?

Yes. Clearing only the still-current rejected promise is the narrowest maintainable fix because it preserves successful caching while allowing recovery from transient read failures.

Label justifications:

P2: The PR fixes a normal CLI reliability bug with a small, well-bounded change and limited blast radius.

What I checked:

Current-main bug path: Current main memoizes the first config snapshot promise with configSnapshotPromise ??= readConfigFileSnapshot(), so a rejected promise can be returned again by later calls in the same process. (src/cli/program/config-guard.ts:33, 1f794d2816d1)
Patch behavior: The PR head stores the pending read, attaches a rejection handler, and clears the module cache only if the rejected promise is still the current cached promise. (src/cli/program/config-guard.ts:33, a46b5ec5c7b0)
Regression coverage: The added test forces the non-Vitest cached path, makes the first snapshot read reject, verifies the next call recovers, and verifies the third call reuses the recovered cached snapshot with two total reads. (src/cli/program/config-guard.test.ts:133, a46b5ec5c7b0)
Changelog coverage: The PR adds an Unreleased CLI fix entry crediting the source contribution. (CHANGELOG.md:10, a46b5ec5c7b0)
History provenance: Blame ties the current cached snapshot guard, including the memoized promise line, to commit 83c225b. (src/cli/program/config-guard.ts:19, 83c225b2430e)
Source PR proof: The linked source PR body reports a focused Vitest run passing and a manual runtime probe with {reads:2, results:[first rejection, second recovery, third cached success]}; this replacement branch preserves that fix and adds the changelog. (9fafa21383da)

Likely related people:

steipete: git blame and git show show commit 83c225b introduced src/cli/program/config-guard.ts, including the cached snapshot promise behavior reviewed here. (role: introduced current config guard; confidence: high; commits: 83c225b2430e; files: src/cli/program/config-guard.ts, src/cli/program/config-guard.test.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 1f794d2816d1.

clawsweeper · 2026-05-19T03:09:24Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=a46b5ec5c7b07a88f4970e2f5ed86cbfad36ef8f)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-19T03:28:27Z
Merge commit: cbaf85822798

What merged:

This PR clears the cached CLI config snapshot promise when a read rejects, adds a reject-retry-cache regression test, and adds an Unreleased changelog entry.
Reproducibility: yes. Current main clearly caches the first snapshot-read promise, and the source PR supplied a focused reject, recover, cached-success probe; I did not rerun it in this read-only review.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix: retry config snapshot after rejection

The automerge loop is complete.

Automerge progress:

2026-05-19 03:09:09 UTC review passed 7ebf5820dc9d (structured ClawSweeper verdict: pass (sha=7ebf5820dc9da6a85eff1679ccfcf2371e325...)

2026-05-19 03:09:24 UTC repair queued 7ebf5820dc9d (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373

2026-05-19 03:14:50 UTC repair started (running) in 0s Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373 automerge-openclaw-openclaw-83931

2026-05-19 03:15:06 UTC validation plan (passed) in 16s Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373 pnpm check:changed; pnpm lint; pnpm check:test-types

2026-05-19 03:15:17 UTC Codex write preflight (passed) in 27s Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373 danger-full-access

2026-05-19 03:20:20 UTC Codex edit 1 a46b5ec5c7b0 (complete) in 5m 30s Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373 exit 0

2026-05-19 03:22:58 UTC validation and review 1 a46b5ec5c7b0 (complete) in 8m 8s Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373 already-current

2026-05-19 03:23:02 UTC repair completed a46b5ec5c7b0 (branch updated) in 8m 13s Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373 initial automerge rebase is delegated to Codex repair

2026-05-19 03:23:02 UTC review queued a46b5ec5c7b0 (after repair)

2026-05-19 03:28:20 UTC automerge wait a46b5ec5c7b0 (ready) in 13m 31s Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373 checks and exact-head review are ready

2026-05-19 03:28:21 UTC repair finished a46b5ec5c7b0 (pushed) in 13m 32s Run: https://github.com/openclaw/clawsweeper/actions/runs/26073779373 repair_contributor_branch

2026-05-19 03:27:45 UTC review passed a46b5ec5c7b0 (structured ClawSweeper verdict: pass (sha=a46b5ec5c7b07a88f4970e2f5ed86cbfad36e...)

2026-05-19 03:28:28 UTC merged a46b5ec5c7b0 (merged by ClawSweeper automerge)

Summary: - This PR clears the cached CLI config snapshot promise when a read rejects, adds a reject-retry-cache regression test, and adds an Unreleased changelog entry. - Reproducibility: yes. Current main clearly caches the first snapshot-read promise, and the source PR supplied a focused reject, recover, cached-success probe; I did not rerun it in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix: retry config snapshot after rejection Validation: - ClawSweeper review passed for head a46b5ec5c7b07a88f4970e2f5ed86cbfad36ef8f. - Required merge gates passed before the squash merge. Prepared head SHA: a46b5ec5c7b07a88f4970e2f5ed86cbfad36ef8f Review: openclaw/openclaw#83944 (comment) Co-authored-by: honor2030 <19909783+honor2030@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

Summary: - This PR clears the cached CLI config snapshot promise when a read rejects, adds a reject-retry-cache regression test, and adds an Unreleased changelog entry. - Reproducibility: yes. Current main clearly caches the first snapshot-read promise, and the source PR supplied a focused reject, recover, cached-success probe; I did not rerun it in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix: retry config snapshot after rejection Validation: - ClawSweeper review passed for head a46b5ec. - Required merge gates passed before the squash merge. Prepared head SHA: a46b5ec Review: openclaw#83944 (comment) Co-authored-by: honor2030 <19909783+honor2030@users.noreply.github.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

clawsweeper Bot mentioned this pull request May 19, 2026

fix: retry config snapshot after rejection #83931

Closed

25 tasks

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 19, 2026

honor2030 and others added 2 commits May 19, 2026 03:15

fix: retry config snapshot after rejection

9fafa21

fix: retry config snapshot after rejection

a46b5ec

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-83931 branch from 7ebf582 to a46b5ec Compare May 19, 2026 03:23

clawsweeper Bot merged commit cbaf858 into main May 19, 2026
97 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-83931 branch May 19, 2026 03:28

kilo-code-bot Bot mentioned this pull request May 19, 2026

[pull] main from openclaw:main qq958691165/openclaw#4

Open

github-actions Bot mentioned this pull request May 19, 2026

📡 Upstream Digest — 2026-05-19 07:37 UTC curtismercier/openclaw-mods#896

Open

This was referenced May 19, 2026

fix(cli): clear config snapshot cache on rejection (#83855) #83865

Closed

fix(doctor): handle gateway SecretRefs in auth checks #84224

Merged

fix(ios): stabilize chat streaming layout and session flow #50483

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: retry config snapshot after rejection#83944

fix: retry config snapshot after rejection#83944
clawsweeper[bot] merged 2 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83931

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clawsweeper Bot commented May 19, 2026

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 19, 2026 •

edited

Loading

clawsweeper Bot commented May 19, 2026 •

edited

Loading