fix(config): include maximum in ceiling validation errors#83916
Closed
leno23 wants to merge 1 commit into
Closed
Conversation
|
Closing this PR because the author has more than 20 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
too_bigschema failures.session.agentToAgent.maxPingPongTurnsshowing the maximum allowed value in the operator-facing error.Tests
node --no-maglev node_modules/vitest/vitest.mjs run src/config/validation.allowed-values.test.ts -t "includes maximum values"(RED before implementation)node --no-maglev node_modules/vitest/vitest.mjs run src/config/validation.allowed-values.test.tsnode_modules/.bin/oxfmt --check src/config/validation.ts src/config/validation.allowed-values.test.tsnode scripts/run-oxlint.mjs src/config/validation.ts src/config/validation.allowed-values.test.tsgit diff --checkVerification
Behavior addressed: Config schema ceiling rejections now append the concrete maximum value exposed by Zod
too_bigissues.Real environment tested: Local macOS checkout on branch
fix/config-max-error-message.Exact steps or command run after this patch:
node --no-maglev node_modules/vitest/vitest.mjs run src/config/validation.allowed-values.test.ts;node_modules/.bin/oxfmt --check src/config/validation.ts src/config/validation.allowed-values.test.ts;node scripts/run-oxlint.mjs src/config/validation.ts src/config/validation.allowed-values.test.ts;git diff --check.Evidence after fix:
src/config/validation.allowed-values.test.tspassed 8/8 tests; oxfmt and oxlint exited 0;git diff --checkexited 0.Observed result after fix: The validation issue for
session.agentToAgent.maxPingPongTurns: 21isToo big: expected number to be <=20 (maximum: 20).What was not tested: Full
pnpm check:changed; local pnpm dependency reconciliation attempted installs and timed out on registry optional package downloads.Closes #52500