-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
fix: config schema ceiling rejections should explicitly state the maximum allowed value #52500
Copy link
Copy link
Closed
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.
Description
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.clawsweeper:fix-shape-clearClawSweeper found a clear likely implementation shape for this issue.ClawSweeper found a clear likely implementation shape for this issue.clawsweeper:queueable-fixClawSweeper marked this issue as an existing queue_fix_pr work candidate.ClawSweeper marked this issue as an existing queue_fix_pr work candidate.clawsweeper:source-reproClawSweeper found a high-confidence source-level issue reproduction.ClawSweeper found a high-confidence source-level issue reproduction.issue-rating: 🦞 diamond lobsterVery strong issue quality with high-confidence source-level or clear reproduction.Very strong issue quality with high-confidence source-level or clear reproduction.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Summary
When a config value is rejected because it exceeds a schema-enforced ceiling, the error message does not state what the maximum allowed value is. The operator is told their value was rejected but not what value would be accepted.
Observed Behavior
Attempting to set
session.agentToAgent.maxPingPongTurnsto 10 produced a rejection. The error did not include the maximum allowed value (5). The operator had no way to know the ceiling from the error message alone; it required reading source code or documentation to discover.Expected Behavior
Schema rejection errors for ceiling-constrained values should include the constraint explicitly:
This applies to all schema-validated ceiling constraints, not just
maxPingPongTurns.Why This Matters
Silent rejections that don't explain the constraint force operators to either (a) guess at valid values by trial and error, (b) read source code, or (c) file a support request. All three are avoidable with a one-line improvement to the error message. This is especially important for ceiling constraints that reflect non-obvious platform decisions (like a loop guard ceiling at 5) rather than obviously reasonable limits.
Priority
MEDIUM — does not block functionality but materially degrades the operator debugging experience and wastes time during incidents.
Requested By
Barry (2026-03-22). Escalated via Nolan Cross (Orchestrator).