Skip to content

fix(memory-wiki): preserve fs-safe write diagnostics#83839

Merged
clawsweeper[bot] merged 3 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83776
May 19, 2026
Merged

fix(memory-wiki): preserve fs-safe write diagnostics#83839
clawsweeper[bot] merged 3 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83776

Conversation

@clawsweeper

@clawsweeper clawsweeper Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Makes #83776 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

  • Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Inherited issue-closing references from the source PR:
Fixes #83740

Co-author credit kept:

fish notes: model gpt-5.5, reasoning high; reviewed against e38ae3b.

@clawsweeper clawsweeper Bot added size: S extensions: memory-wiki clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge proof: supplied External PR includes structured after-fix real behavior proof. proof: sufficient ClawSweeper judged the real behavior proof convincing. P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. clawsweeper Tracked by ClawSweeper automation labels May 19, 2026
@clawsweeper clawsweeper Bot mentioned this pull request May 19, 2026
Closed
@openclaw-barnacle openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 19, 2026
@clawsweeper

clawsweeper Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The branch narrows Memory Wiki imported-source FsSafeError wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.

Reproducibility: yes. Source inspection shows current main catches all imported-source FsSafeErrors with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

PR rating
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Summary: Focused, well-proved bug fix with regression coverage and no blocking review findings.

What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

PR egg
✨ Hatched: 🌱 uncommon Mossy Review Wisp

        .--^^^^--.           
     .-'  o    o  '-.        
    /       \__/      \      
   |    /\  ____  /\   |     
   |   /  \/____\/  \  |     
    \  \_.------._/  /       
     '._  `----'  _.'        
        '-.____.-'           
       _/|_|  |_|\_          
      /__|      |__\         
       .-----------.         
      '-------------'

Rarity: 🌱 uncommon.
Trait: polishes edge cases.
Share on X: post this hatch
Copy: My PR egg hatched a 🌱 uncommon Mossy Review Wisp in ClawSweeper.

What is this egg doing here?
  • Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
  • The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
  • How to hatch it: reach status: 👀 ready for maintainer look or status: 🚀 automerge armed; that usually means sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness.
  • The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
  • Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Real behavior proof
Sufficient (live_output): The linked source PR provides copied after-fix live output from a real temporary Memory Wiki bridge vault/workspace using the actual sync path.

Next step before merge
No repair lane is needed; this automerge replacement PR is focused, already has source proof, and has no actionable review findings.

Security
Cleared: The diff stays in Memory Wiki diagnostics/tests, preserves fs-safe fail-closed behavior, and adds no dependency, workflow, secret, or permission changes.

Review details

Best possible solution:

Merge this replacement after normal maintainer and CI gates so the open Memory Wiki issue is fixed in the active PR while preserving source author credit.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main catches all imported-source FsSafeErrors with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Is this the best way to solve the issue?

Yes. The patch keeps symlink/path-alias failures fail-closed while surfacing the real fs-safe code for non-symlink failures and preventing directory collisions from being removed as regular-file hardlinks.

Label justifications:

  • P2: This fixes a real Memory Wiki imported-source diagnostic bug with limited plugin-local blast radius.

What I checked:

  • Current-main bug path: Current main removes any existing imported-source page path with nlink > 1 and wraps every imported-source write FsSafeError as Refusing to write imported source page through symlink, regardless of the actual fs-safe code. (extensions/memory-wiki/src/source-page-shared.ts:54, 6f18decb7a2c)
  • PR implementation: The PR head adds isRegularFileStat, uses it before hardlink cleanup, and preserves symlink wording only for symlink and path-alias; other fs-safe errors keep the concrete code and message. (extensions/memory-wiki/src/source-page-shared.ts:77, e38ae3b99896)
  • Regression coverage: The PR adds bridge tests for populated and empty directory collisions, asserting non-symlink diagnostics and that an empty directory is not removed as a hardlinked regular file. (extensions/memory-wiki/src/bridge.test.ts:395, e38ae3b99896)
  • Dependency contract: @openclaw/fs-safe@0.2.4 defines distinct FsSafeErrorCode values including not-file, not-empty, path-mismatch, symlink, and path-alias; its root write path rejects non-files, symlinks, hardlinks, and path mismatches fail-closed.
  • Source PR proof and replacement context: The closed source PR body provides copied after-fix live output from a real temporary Memory Wiki bridge sync showing not-file, no stale symlink wording, and the directory still present; the replacement PR preserves that source credit and adds only the repair follow-up plus changelog. (e38ae3b99896)
  • Feature history: History ties the central write helper to the source-page dedupe refactor and the surrounding bridge/imported-source sync to earlier Memory Wiki bridge work. (extensions/memory-wiki/src/source-page-shared.ts:1, efd9aaea3f3e)

Likely related people:

  • steipete: Introduced the shared writeImportedSourcePage helper in the Memory Wiki source-page dedupe refactor and prepared the release snapshot that contains the current fs-safe write path. (role: source-page refactor owner; confidence: medium; commits: efd9aaea3f3e, 50a2481652b6; files: extensions/memory-wiki/src/source-page-shared.ts, extensions/memory-wiki/src/bridge.ts, extensions/memory-wiki/src/unsafe-local.ts)
  • vincentkoc: Added the Memory Wiki bridge sync and incremental imported-source sync behavior that feed the affected write path. (role: feature introducer; confidence: high; commits: fbbe2a167504, a78c4de737c5; files: extensions/memory-wiki/src/bridge.ts, extensions/memory-wiki/src/bridge.test.ts)
  • zhouhe-xydt: Recently changed adjacent bridge source filename behavior and tests in the same Memory Wiki bridge test surface. (role: adjacent bridge test contributor; confidence: low; commits: 879bb5dd911e; files: extensions/memory-wiki/src/bridge.ts, extensions/memory-wiki/src/bridge.test.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 6f18decb7a2c.

@clawsweeper clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 19, 2026
@clawsweeper

clawsweeper Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=e38ae3b99896709800954fca996813812c65694b)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-19T01:24:55Z
Merge commit: 1a242cd4f501

What merged:

  • The branch narrows Memory Wiki imported-source FsSafeError wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
  • Reproducibility: yes. Source inspection shows current main catches all imported-source FsSafeErrors with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:

  • PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
  • PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

The automerge loop is complete.

Automerge progress:

  • 2026-05-19 01:17:58 UTC review passed e38ae3b99896 (structured ClawSweeper verdict: pass (sha=e38ae3b99896709800954fca996813812c656...)
  • 2026-05-19 01:22:15 UTC merge check queued e38ae3b99896 (checks and exact-head review are ready)
  • 2026-05-19 01:22:56 UTC review queued e38ae3b99896 (queued)
  • 2026-05-19 01:24:57 UTC merged e38ae3b99896 (merged by ClawSweeper automerge)

@clawsweeper clawsweeper Bot merged commit 1a242cd into main May 19, 2026
172 of 188 checks passed
@clawsweeper clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-83776 branch May 19, 2026 01:24
@github-actions github-actions Bot mentioned this pull request May 19, 2026
Open
markfietje pushed a commit to markfietje/openclaw that referenced this pull request May 20, 2026
@clawsweeper @TurboTheTurtle @Takhoffman
fix(memory-wiki): preserve fs-safe write diagnostics (#83839)
8b552d4 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b99896709800954fca996813812c65694b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b99896709800954fca996813812c65694b
Review: openclaw/openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
markfietje pushed a commit to markfietje/openclaw that referenced this pull request May 20, 2026
@clawsweeper @TurboTheTurtle @Takhoffman
fix(memory-wiki): preserve fs-safe write diagnostics (#83839)
6490d44 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b99896709800954fca996813812c65694b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b99896709800954fca996813812c65694b
Review: openclaw/openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
@clawsweeper @TurboTheTurtle
@Takhoffman @SebTardif
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
2e83eed 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
@clawsweeper @TurboTheTurtle
@Takhoffman @SebTardif
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
9dcd3ef 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
@clawsweeper @TurboTheTurtle
@Takhoffman @SebTardif
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
d4638a5 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
@clawsweeper @TurboTheTurtle @Takhoffman
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
8b1dd4f 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
galiniliev pushed a commit to galiniliev/openclaw that referenced this pull request May 25, 2026
@clawsweeper @TurboTheTurtle @Takhoffman
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
4103d27 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
@clawsweeper @TurboTheTurtle
@Takhoffman @SebTardif
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
e5b37ee 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
@clawsweeper @TurboTheTurtle
@Takhoffman @SebTardif
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
207c07c 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
@clawsweeper @TurboTheTurtle
@Takhoffman @SebTardif
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
4434f86 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
@clawsweeper @TurboTheTurtle @Takhoffman
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
6035326 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SYU8384 pushed a commit to SYU8384/openclaw that referenced this pull request Jun 3, 2026
@clawsweeper @TurboTheTurtle @Takhoffman
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
9d71a35 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
@clawsweeper @TurboTheTurtle @Takhoffman
fix(memory-wiki): preserve fs-safe write diagnostics (openclaw#83839)
68a8f99 
Summary:
- The branch narrows Memory Wiki imported-source `FsSafeError` wrapping, adds directory-collision bridge regressions, and adds a changelog entry crediting the source PR.
- Reproducibility: yes. Source inspection shows current main catches all imported-source `FsSafeError`s with symlink wording, and the linked source PR includes live bridge-sync output for the directory-collision path.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): normalize source page stat guard
- PR branch already contained follow-up commit before automerge: fix(memory-wiki): preserve fs-safe write diagnostics

Validation:
- ClawSweeper review passed for head e38ae3b.
- Required merge gates passed before the squash merge.

Prepared head SHA: e38ae3b
Review: openclaw#83839 (comment)

Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge clawsweeper Tracked by ClawSweeper automation extensions: memory-wiki P2 Normal backlog priority with limited blast radius. proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. size: S status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

memory-wiki: "Refusing to write imported source page through symlink" fires for non-symlink FsSafeError causes

1 participant

@TurboTheTurtle