Skip to content

fix(skills): refresh snapshots when watch roots change#83823

Merged
clawsweeper[bot] merged 2 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83800
May 19, 2026
Merged

fix(skills): refresh snapshots when watch roots change#83823
clawsweeper[bot] merged 2 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83800

Conversation

@clawsweeper

@clawsweeper clawsweeper Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

Makes #83800 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

  • Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Inherited issue-closing references from the source PR:
Fixes #83782

Co-author credit kept:

fish notes: model gpt-5.5, reasoning high; reviewed against 2677dcc.

@clawsweeper clawsweeper Bot added agents Agent runtime and tooling size: S clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge proof: supplied External PR includes structured after-fix real behavior proof. proof: sufficient ClawSweeper judged the real behavior proof convincing. P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. clawsweeper Tracked by ClawSweeper automation labels May 19, 2026
@clawsweeper clawsweeper Bot mentioned this pull request May 19, 2026
Closed
@openclaw-barnacle openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 19, 2026
@clawsweeper

clawsweeper Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The replacement PR adds a watch-targets skills snapshot invalidation when ensureSkillsWatcher rebuilds for a changed root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.

Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targets without bumping the snapshot version, and the session path reads the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

PR rating
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster
Patch quality: 🐚 platinum hermit
Summary: Focused, likely mergeable bug fix with strong terminal proof and targeted regression tests; live end-to-end mount proof would only add extra confidence.

Rank-up moves:

  • none
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

PR egg
✨ Hatched: 🥚 common Sunspot Test Hopper

        .--^^^^--.           
     .-'  o    o  '-.        
    /       \__/      \      
   |    /\  ____  /\   |     
   |   /  \/____\/  \  |     
    \  \_.------._/  /       
     '._  `----'  _.'        
        '-.____.-'           
       _/|_|  |_|\_          
      /__|      |__\         
       .-----------.         
      '-------------'

Rarity: 🥚 common.
Trait: sniffs out flaky tests.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Sunspot Test Hopper in ClawSweeper.

What is this egg doing here?
  • Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
  • The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
  • How to hatch it: reach status: 👀 ready for maintainer look or status: 🚀 automerge armed; that usually means sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness.
  • The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
  • Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Real behavior proof
Sufficient (terminal): The credited source PR body includes after-fix terminal output from a real local checkout showing a watch-root change emits watch-targets and increases the workspace snapshot version.

Risk before merge
Why this matters: - The proof covers the underlying watcher/version signal and regression tests cover session ordering, but it does not include a live Gateway plus Claude CLI --plugin-dir mount check.

Maintainer options:

  1. Decide the mitigation before merge
    Land the bounded watcher-version invalidation and ordering fix after required merge gates pass, leaving broader skills exposure config refresh work to fix(skills): refresh snapshots after skill exposure config changes #82365.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge
No repair lane is needed; this automerge-opted replacement PR already contains the narrow fix, tests, and sufficient proof, so remaining action is normal CI and merge gating.

Security
Cleared: The diff only changes internal skills snapshot invalidation logic, focused tests, and changelog text; I found no concrete security or supply-chain regression.

Review details

Best possible solution:

Land the bounded watcher-version invalidation and ordering fix after required merge gates pass, leaving broader skills exposure config refresh work to #82365.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main rebuilds the skills watcher on changed root targets without bumping the snapshot version, and the session path reads the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Is this the best way to solve the issue?

Yes. The PR uses the existing snapshot-version invalidation contract and fixes caller ordering instead of adding a parallel refresh mechanism; the only useful extra would be optional live Gateway mount proof, not a different code shape.

Label justifications:

  • P2: This is a normal-priority bug fix for stale existing-session skills state with limited agents/skills blast radius.

What I checked:

  • Current main watcher path: On current main, ensureSkillsWatcher rebuilds the chokidar watcher when pathsKey changes, but it reaches watchers.set(workspaceDir, state) without bumping the workspace skills snapshot version. (src/agents/skills/refresh.ts:125, 9b517b50cb2c)
  • Current main session ordering: On current main, ensureSkillSnapshot reads getSkillsSnapshotVersion(workspaceDir) before calling ensureSkillsWatcher, so a watcher-side invalidation during setup would not affect the reuse gate for that turn. (src/auto-reply/reply/session-updates.ts:262, 9b517b50cb2c)
  • PR watcher fix: The PR diff records whether an existing watcher changed root targets, then calls bumpSkillsSnapshotVersion with reason watch-targets after registering the replacement watcher state. (src/agents/skills/refresh.ts:127, 2677dcc35aea)
  • PR session-order fix: The PR moves the snapshot-version read after ensureSkillsWatcher, so the rebuilt watcher can invalidate the existing session snapshot before the refresh decision is made. (src/auto-reply/reply/session-updates.ts:262, 2677dcc35aea)
  • Regression coverage: The PR adds focused tests for root-set watcher changes emitting watch-targets and for ensureSkillSnapshot observing the watcher-side version bump in the same call. (src/auto-reply/reply/session-updates.test.ts:200, 2677dcc35aea)
  • Real behavior proof: The credited source PR body includes terminal output from a real local OpenClaw checkout showing the second watcher setup emitted watch-targets and increased the workspace snapshot version after changing extraDirs. (2677dcc35aea)

Likely related people:

  • steipete: Authored earlier skills watcher stabilization and session skills snapshot hydration work that define the watcher/version contract this PR extends. (role: feature-history owner; confidence: high; commits: eed6113359ed, 0e046f61abcf, 70ef23475392; files: src/agents/skills/refresh.ts, src/auto-reply/reply/session-updates.ts)
  • shakkernerd: Split the shared skills refresh state into refresh-state.ts, which is the type and versioning surface this PR extends. (role: adjacent refactor owner; confidence: medium; commits: 4499d572fa76; files: src/agents/skills/refresh-state.ts, src/agents/skills/refresh.ts)
  • xantorres: Added the existing config-change skills snapshot invalidation path, the closest current invalidation behavior to this watcher-root fix. (role: adjacent invalidation contributor; confidence: medium; commits: b23d59a522ba; files: src/gateway/config-reload.ts, src/agents/skills/refresh-state.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 9b517b50cb2c.

@clawsweeper clawsweeper Bot added status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. and removed status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 19, 2026
@clawsweeper clawsweeper Bot merged commit f1a55cb into main May 19, 2026
171 of 180 checks passed
@clawsweeper

clawsweeper Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=2677dcc35aea1970121541403647fcf135c47527)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-19T00:36:28Z
Merge commit: f1a55cbd5203

What merged:

  • The replacement PR adds a watch-targets skills snapshot invalidation when ensureSkillsWatcher rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
  • Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:

  • PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

The automerge loop is complete.

Automerge progress:

  • 2026-05-19 00:36:17 UTC review passed 2677dcc35aea (structured ClawSweeper verdict: pass (sha=2677dcc35aea1970121541403647fcf135c47...)
  • 2026-05-19 00:36:30 UTC merged 2677dcc35aea (merged by ClawSweeper automerge)

@clawsweeper clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-83800 branch May 19, 2026 00:36
@github-actions github-actions Bot mentioned this pull request May 19, 2026
Open
@clawsweeper clawsweeper Bot mentioned this pull request May 19, 2026
Closed
1 task
markfietje pushed a commit to markfietje/openclaw that referenced this pull request May 20, 2026
@clawsweeper @Takhoffman
fix(skills): refresh snapshots when watch roots change (#83823)
c90c432 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc35aea1970121541403647fcf135c47527.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc35aea1970121541403647fcf135c47527
Review: openclaw/openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
markfietje pushed a commit to markfietje/openclaw that referenced this pull request May 20, 2026
@clawsweeper @Takhoffman
fix(skills): refresh snapshots when watch roots change (#83823)
69ca0d2 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc35aea1970121541403647fcf135c47527.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc35aea1970121541403647fcf135c47527
Review: openclaw/openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
@clawsweeper @Takhoffman @SebTardif
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
dc902c3 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
@clawsweeper @Takhoffman @SebTardif
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
696c3c8 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
@clawsweeper @Takhoffman @SebTardif
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
c0f8906 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
@clawsweeper @Takhoffman
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
9fffba0 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
galiniliev pushed a commit to galiniliev/openclaw that referenced this pull request May 25, 2026
@clawsweeper @Takhoffman
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
41ce57f 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
@clawsweeper @Takhoffman @SebTardif
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
d212677 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
@clawsweeper @Takhoffman @SebTardif
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
5494a1c 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
@clawsweeper @Takhoffman @SebTardif
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
2792f89 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
@clawsweeper @Takhoffman
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
a897c2f 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
SYU8384 pushed a commit to SYU8384/openclaw that referenced this pull request Jun 3, 2026
@clawsweeper @Takhoffman
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
2d0c46b 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
@clawsweeper @Takhoffman
fix(skills): refresh snapshots when watch roots change (openclaw#83823)
f002dd2 
Summary:
- The replacement PR adds a `watch-targets` skills snapshot invalidation when `ensureSkillsWatcher` rebuilds f ... root set, reads the snapshot version after watcher setup, adds regression tests, and updates the changelog.
- Reproducibility: yes. Source inspection shows current main rebuilds the skills watcher on changed root targe ... the version before watcher setup; I did not run a live Gateway mount reproduction in this read-only review.

Automerge notes:
- PR branch already contained follow-up commit before automerge: fix(skills): refresh snapshots when watch roots change

Validation:
- ClawSweeper review passed for head 2677dcc.
- Required merge gates passed before the squash merge.

Prepared head SHA: 2677dcc
Review: openclaw#83823 (comment)

Co-authored-by: hclsys <hclsys@openclaw.ai>
Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Approved-by: takhoffman
Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

agents Agent runtime and tooling clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge clawsweeper Tracked by ClawSweeper automation P2 Normal backlog priority with limited blast radius. proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: S status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Skill registry: changes to skills.load.extraDirs do not propagate to existing per-session skillsSnapshot

0 participants