fix(auto-reply): honor webchat textChunkLimit/chunkMode config overrides [AI-assisted]#83742
Conversation
The webchat channel was explicitly bypassed in resolveTextChunkLimit and resolveChunkMode, hardcoding the 4000-char default and ignoring any channels.webchat.textChunkLimit override in user config. This made long WebChat assistant responses get cut at ~4000 chars with no escape hatch. Drop the INTERNAL_MESSAGE_CHANNEL special-case so webchat goes through the same provider config lookup as every other channel. The 4000-char fallback still applies when no override is configured, preserving existing behavior for users who do not set channels.webchat.textChunkLimit. Closes #83658
…des [AI-assisted]
|
Codex review: passed. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallback for provider PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. PR egg Rarity: 🥚 common. What is this egg doing here?
Real behavior proof Mantis proof suggestion Next step before merge Security Review detailsBest possible solution: Land this replacement PR after the normal automerge/check gates so explicit WebChat chunk overrides work while default WebChat chunking remains unchanged. Do we have a high-confidence way to reproduce the issue? Yes, from source inspection rather than runtime execution: current main returns the fallback for provider Is this the best way to solve the issue? Yes. Removing only the Label justifications:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 583a60f8b5a4. |
|
ClawSweeper 🐠 automerge status This repair pass finished without changing the PR. ClawSweeper checked the branch and found no safe patch to push this time. Executor outcome: no planned fix actions. Worker actions:
Nothing moved downstream from this pass: no branch update, replacement PR, merge, or re-review. fish notes: model gpt-5.5, reasoning high; reviewed against cd9ac01. Automerge progress:
|
…des [AI-assisted] (#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01a363412f3dc56730d58e9cb05742d4a8c. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01a363412f3dc56730d58e9cb05742d4a8c Review: openclaw/openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01a363412f3dc56730d58e9cb05742d4a8c. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01a363412f3dc56730d58e9cb05742d4a8c Review: openclaw/openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
…des [AI-assisted] (openclaw#83742) Summary: - This PR removes the WebChat special-case from auto-reply chunk limit/mode resolution, adds WebChat override regression tests, and records the fix in the changelog. - Reproducibility: yes. from source inspection rather than runtime execution: current main returns the fallbac ... bchat` before reading `cfg.channels`, so a configured `channels.webchat.textChunkLimit` cannot take effect. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(auto-reply): honor webchat textChunkLimit/chunkMode config overri… Validation: - ClawSweeper review passed for head cd9ac01. - Required merge gates passed before the squash merge. Prepared head SHA: cd9ac01 Review: openclaw#83742 (comment) Co-authored-by: luyao618 <364939526@qq.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
Makes #83713 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
ClawSweeper 🐠 replacement reef notes:
Inherited issue-closing references from the source PR:
Closes #83658
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against cd9ac01.