fix(agents): preserve run-mode keep subagents past session sweep TTL (#83132) by clawsweeper[bot] · Pull Request #83226 · openclaw/openclaw

clawsweeper · 2026-05-17T18:21:36Z

Makes #83168 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-83168
Source PRs: fix(agents): preserve run-mode keep subagents past session sweep TTL (#83132) #83168
Credit: Source PR: fix(agents): preserve run-mode keep subagents past session sweep TTL (#83132) #83168
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Co-author credit kept:

@yetval: Co-authored-by: Yuval Dinodia 102706514+yetval@users.noreply.github.com

fish notes: model gpt-5.5, reasoning high; reviewed against 32faf5c.

The sweeper applied SESSION_RUN_TTL_MS (5 minutes) to any registry entry without archiveAtMs. Run-mode subagents spawned with cleanup:"keep" also have archiveAtMs=undefined by design, so they were pruned five minutes after cleanup completed — directly contradicting the keep semantic the user requested. Gate the absolute-TTL prune on spawnMode === "session" so run-mode keep entries stay registered. Session-mode runs retain the existing five-minute window. Refs #83132

…83132)

clawsweeper · 2026-05-17T18:22:42Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by maintainer comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors can comment @clawsweeper re-review or @clawsweeper re-run on their own open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The PR exempts run-mode cleanup: "keep" subagent registry entries from the session-mode sweep TTL, adds focused regression coverage, and records the fix in the changelog.

Reproducibility: yes. Current main source shows a run-mode keep entry has no archiveAtMs and then matches the no-archive sweep TTL; the linked source PR also provides before/after terminal proof against a real persisted runs.json path.

Real behavior proof
Sufficient (terminal): The linked source PR supplies after-fix terminal proof from a real persisted registry repro, including the current-main failure and patched success.

Next step before merge
No ClawSweeper repair job is needed; this automerge replacement has no blocking review findings and should be handled by normal check and merge gates.

Security
Cleared: The diff only changes agents registry retention logic, a regression test, and changelog text; it adds no dependencies, workflows, secrets handling, or new code-execution path.

Review details

Best possible solution:

Land this focused agents fix once the normal automerge checks pass; no new config knob or broader registry migration is needed.

Do we have a high-confidence way to reproduce the issue?

Yes. Current main source shows a run-mode keep entry has no archiveAtMs and then matches the no-archive sweep TTL; the linked source PR also provides before/after terminal proof against a real persisted runs.json path.

Is this the best way to solve the issue?

Yes. The PR changes the smallest implicated branch by exempting non-session keep entries before the session TTL logic, while leaving delete-mode archive cleanup and session-mode TTL behavior intact.

What I checked:

Current registration contract: Current main sets archiveAtMs to undefined for both session-mode runs and any cleanup: "keep" run, so run-mode keep entries enter the no-archive sweep branch. (src/agents/subagent-registry-run-manager.ts:474, 800a0d316636)
Current main sweep bug: Current main applies SESSION_RUN_TTL_MS to every entry without archiveAtMs after cleanup completes, which includes run-mode keep entries despite the session-mode comment. (src/agents/subagent-registry.ts:866, 800a0d316636)
Patch behavior: The PR head adds a guard before the no-archive TTL branch so non-session cleanup: "keep" entries continue to survive the sweep while session-mode TTL behavior remains in place. (src/agents/subagent-registry.ts:866, 32faf5cf329f)
Regression coverage: The new test registers a run-mode keep entry, waits for cleanup bookkeeping, advances time ten minutes, runs the sweeper, and asserts the run id remains listed. (src/agents/subagent-registry.test.ts:770, 32faf5cf329f)
User-facing contract: The subagents docs define cleanup with default keep, while delete is the mode documented to archive immediately after announce. Public docs: docs/tools/subagents.md. (docs/tools/subagents.md:219, 800a0d316636)
History provenance: The session TTL branch was introduced by the TTL cleanup change that added SESSION_RUN_TTL_MS and started sweeping no-archive entries after cleanup; this explains why run-mode keep entries began matching the session-mode path. (src/agents/subagent-registry.ts:195, 820dc3852530)

Likely related people:

@steipete: Current blame and shortlog show substantial recent work on the subagent registry files, including the subagent announce/archive implementation and later registry refactors. (role: recent area contributor; confidence: high; commits: 75c66acfd828, f862685ed8e4, f0fc8c27d397; files: src/agents/subagent-registry.ts, src/agents/subagent-registry-run-manager.ts, src/agents/subagent-registry.test.ts)
@Takhoffman: Recent current-main commits changed deferred subagent cleanup and expiry behavior adjacent to cleanupCompletedAt and registry sweep handling; this PR was also automerge-requested by this account. (role: recent cleanup contributor; confidence: medium; commits: 5e9ea804d4e4, c3744fbfc468; files: src/agents/subagent-registry.ts, src/agents/subagent-registry.test.ts)
XING: The no-archive session sweep TTL was added in the TTL cleanup commit that made completed no-archive registry entries eligible for pruning after five minutes. (role: introduced adjacent TTL behavior; confidence: medium; commits: 820dc3852530; files: src/agents/subagent-registry.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 800a0d316636.

clawsweeper · 2026-05-17T18:27:57Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=32faf5cf329f41a5aa00bff25eda8904dfca231b)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-17T18:27:54Z
Merge commit: 3e765263dd6a

What merged:

The PR exempts run-mode cleanup: "keep" subagent registry entries from the session-mode sweep TTL, adds focused regression coverage, and records the fix in the changelog.
Reproducibility: yes. Current main source shows a run-mode keep entry has no archiveAtMs and then matches ... ; the linked source PR also provides before/after terminal proof against a real persisted runs.json path.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix(agents): preserve run-mode keep subagents past session sweep TTL …

The automerge loop is complete.

Automerge progress:

2026-05-17 18:27:41 UTC review passed 32faf5cf329f (structured ClawSweeper verdict: pass (sha=32faf5cf329f41a5aa00bff25eda8904dfca2...)

2026-05-17 18:27:56 UTC merged 32faf5cf329f (merged by ClawSweeper automerge)

…penclaw#83132) (openclaw#83226) Summary: - The PR exempts run-mode `cleanup: "keep"` subagent registry entries from the session-mode sweep TTL, adds focused regression coverage, and records the fix in the changelog. - Reproducibility: yes. Current main source shows a run-mode keep entry has no `archiveAtMs` and then matches ... ; the linked source PR also provides before/after terminal proof against a real persisted `runs.json` path. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(agents): preserve run-mode keep subagents past session sweep TTL … Validation: - ClawSweeper review passed for head 32faf5c. - Required merge gates passed before the squash merge. Prepared head SHA: 32faf5c Review: openclaw#83226 (comment) Co-authored-by: yetval <yetvald@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

…(#83132) (#83226) Summary: - The PR exempts run-mode `cleanup: "keep"` subagent registry entries from the session-mode sweep TTL, adds focused regression coverage, and records the fix in the changelog. - Reproducibility: yes. Current main source shows a run-mode keep entry has no `archiveAtMs` and then matches ... ; the linked source PR also provides before/after terminal proof against a real persisted `runs.json` path. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(agents): preserve run-mode keep subagents past session sweep TTL … Validation: - ClawSweeper review passed for head 32faf5cf329f41a5aa00bff25eda8904dfca231b. - Required merge gates passed before the squash merge. Prepared head SHA: 32faf5cf329f41a5aa00bff25eda8904dfca231b Review: openclaw/openclaw#83226 (comment) Co-authored-by: yetval <yetvald@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

…penclaw#83132) (openclaw#83226) Summary: - The PR exempts run-mode `cleanup: "keep"` subagent registry entries from the session-mode sweep TTL, adds focused regression coverage, and records the fix in the changelog. - Reproducibility: yes. Current main source shows a run-mode keep entry has no `archiveAtMs` and then matches ... ; the linked source PR also provides before/after terminal proof against a real persisted `runs.json` path. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(agents): preserve run-mode keep subagents past session sweep TTL … Validation: - ClawSweeper review passed for head 32faf5c. - Required merge gates passed before the squash merge. Prepared head SHA: 32faf5c Review: openclaw#83226 (comment) Co-authored-by: yetval <yetvald@gmail.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>

yetval and others added 2 commits May 17, 2026 18:14

fix(agents): preserve run-mode keep subagents past session sweep TTL (#…

32faf5c

…83132)

clawsweeper Bot mentioned this pull request May 17, 2026

fix(agents): preserve run-mode keep subagents past session sweep TTL (#83132) #83168

Closed

4 tasks

openclaw-barnacle Bot removed proof: supplied External PR includes structured after-fix real behavior proof. proof: sufficient ClawSweeper judged the real behavior proof convincing. labels May 17, 2026

clawsweeper Bot added the proof: sufficient ClawSweeper judged the real behavior proof convincing. label May 17, 2026

clawsweeper Bot merged commit 3e76526 into main May 17, 2026
185 of 202 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-83168 branch May 17, 2026 18:27

ronan-dandelion-cult mentioned this pull request May 24, 2026

Design: subagent-registry.ts — keep-entry sweep behavior (TTL vs survive) karmaterminal/openclaw#773

Open

elliott-dandelion-cult mentioned this pull request May 24, 2026

Design: subagent-registry.ts — keep-entry sweep behavior (TTL vs indefinite survival) karmaterminal/openclaw#777

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(agents): preserve run-mode keep subagents past session sweep TTL (#83132)#83226

fix(agents): preserve run-mode keep subagents past session sweep TTL (#83132)#83226
clawsweeper[bot] merged 2 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83168

clawsweeper Bot commented May 17, 2026

Uh oh!

clawsweeper Bot commented May 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

clawsweeper Bot commented May 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clawsweeper Bot commented May 17, 2026

Uh oh!

clawsweeper Bot commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

clawsweeper Bot commented May 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 17, 2026 •

edited

Loading