Skip to content

fix: restore Codex snapshot tool progress#82917

Merged
steipete merged 1 commit into
mainfrom
fix/codex-snapshot-tool-progress
May 17, 2026
Merged

fix: restore Codex snapshot tool progress#82917
steipete merged 1 commit into
mainfrom
fix/codex-snapshot-tool-progress

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Summary

  • Restore Codex app-server native tool progress when command/tool items only appear in the final turn snapshot.
  • Avoid duplicate progress for items that already started live, running snapshot items, and prior-turn snapshot replays.
  • Add Codex projector regression coverage and changelog entry.

Verification

  • pnpm test extensions/codex/src/app-server/event-projector.test.ts
  • /Users/steipete/Projects/agent-scripts/skills/codex-review/scripts/codex-review --mode local
  • git diff --check

Real behavior proof
Behavior addressed: Telegram /verbose progress for native Codex command/tool calls that only appear in final turn snapshots.
Real environment tested: Local OpenClaw checkout with Codex app-server projector regression coverage.
Exact steps or command run after this patch: pnpm test extensions/codex/src/app-server/event-projector.test.ts
Evidence after fix: New projector regressions emit item/tool start/result from terminal turn/completed commandExecution snapshots, avoid duplicate starts, skip running snapshots, and skip prior-turn snapshot replays.
Observed result after fix: 47 projector tests passed; Codex review reported no accepted/actionable findings.
What was not tested: Live Telegram user roundtrip against the reported install.

@clawsweeper

clawsweeper Bot commented May 17, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: restore Codex snapshot tool progress This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete steipete added the proof: override Maintainer override for the external PR real behavior proof gate. label May 17, 2026
# Conflicts:
#	CHANGELOG.md
@steipete steipete force-pushed the fix/codex-snapshot-tool-progress branch from 1d02c9a to e4c1280 Compare May 17, 2026 05:16
@steipete

Copy link
Copy Markdown
Contributor Author

Verification for e4c1280f0badbfd945aee38f658511c60bec2824:

Local proof:

  • pnpm test extensions/codex/src/app-server/event-projector.test.ts -> 47 passed after the rebase.
  • /Users/steipete/Projects/agent-scripts/skills/codex-review/scripts/codex-review --mode local -> clean, no accepted/actionable findings before commit.
  • git diff --check -> clean before the rebase commit.

CI proof:

  • Live check-runs for e4c1280f0badbfd945aee38f658511c60bec2824 -> 77 success, 0 pending, 0 failing.
  • Relevant runs: CI 25982158011, Workflow Sanity 25982157998, CodeQL Critical Quality 25982157993, OpenGrep PR Diff 25982157994, Real behavior proof 25982157183.

Behavior proof:

  • Before: native Codex command/tool items present only in the final turn/completed snapshot were recorded in transcript state but did not emit normalized item/tool progress events for channel verbose surfaces.
  • After: terminal snapshot-only native tool items synthesize item/tool start/result progress, while already-started items avoid duplicate starts, running snapshots do not fake completion, and prior-turn snapshot replays with item turn ownership are ignored.
  • Not tested live: Telegram roundtrip against the reported install.

@steipete steipete merged commit 421b9e2 into main May 17, 2026
106 checks passed
@steipete steipete deleted the fix/codex-snapshot-tool-progress branch May 17, 2026 05:21
galiniliev pushed a commit to galiniliev/openclaw that referenced this pull request May 20, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
galiniliev pushed a commit to galiniliev/openclaw that referenced this pull request May 25, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
SYU8384 pushed a commit to SYU8384/openclaw that referenced this pull request Jun 3, 2026
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extensions: codex maintainer Maintainer-authored PR proof: override Maintainer override for the external PR real behavior proof gate. size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant