Skip to content

fix: honor explicit message tool allowlists#82889

Merged
steipete merged 1 commit into
mainfrom
fix/message-allow-embedded-weixin
May 17, 2026
Merged

fix: honor explicit message tool allowlists#82889
steipete merged 1 commit into
mainfrom
fix/message-allow-embedded-weixin

Conversation

@steipete

@steipete steipete commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Verification

  • pnpm exec oxfmt --check src/agents/pi-tools.ts src/agents/pi-tools.create-openclaw-coding-tools.test.ts src/agents/openclaw-tools.ts src/agents/openclaw-tools.update-plan.test.ts src/plugins/runtime/types-channel.ts && git diff --check
  • pnpm test src/agents/openclaw-tools.update-plan.test.ts src/agents/pi-tools.create-openclaw-coding-tools.test.ts
  • pnpm test src/plugins/contracts/plugin-sdk-index.test.ts src/plugins/contracts/plugin-sdk-runtime-api-guardrails.test.ts
  • pnpm changed:lanes --json
  • pnpm check:changed via Blacksmith Testbox tbx_01krt1xb26bzqpw3xgs3p5sw5f, GitHub Actions https://github.com/openclaw/openclaw/actions/runs/25980959972
  • Codex review: clean, no accepted/actionable findings

Real behavior proof
Behavior addressed: embedded channel runs can now keep the message tool when it is explicitly allowed by tools.alsoAllow or runtime tool allowlists, even under restrictive profiles such as minimal.
Real environment tested: local repo checkout plus delegated Blacksmith Testbox changed-check.
Exact steps or command run after this patch: pnpm test src/agents/openclaw-tools.update-plan.test.ts src/agents/pi-tools.create-openclaw-coding-tools.test.ts; pnpm check:changed.
Evidence after fix: focused tests cover embedded factory inclusion, config tools.alsoAllow, deny precedence, runtime literal/group/wildcard allowlists, and restrictive profile filtering.
Observed result after fix: focused tests passed; plugin SDK contract tests passed; Testbox check:changed passed with exit 0.
What was not tested: live Weixin send was not run because this checkout does not have a configured Weixin bot session; external @tencent-weixin/openclaw-weixin still needs to move off deprecated low-level runtime helpers for the full channel-side update.

@openclaw-barnacle openclaw-barnacle Bot added agents Agent runtime and tooling size: S maintainer Maintainer-authored PR labels May 17, 2026
@clawsweeper

clawsweeper Bot commented May 17, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: honor explicit message tool allowlists This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete steipete force-pushed the fix/message-allow-embedded-weixin branch from be0c245 to a673a85 Compare May 17, 2026 04:10
@steipete steipete merged commit 06e85d5 into main May 17, 2026
112 of 114 checks passed
@steipete steipete deleted the fix/message-allow-embedded-weixin branch May 17, 2026 04:11
galiniliev pushed a commit to galiniliev/openclaw that referenced this pull request May 20, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
galiniliev pushed a commit to galiniliev/openclaw that referenced this pull request May 25, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
SYU8384 pushed a commit to SYU8384/openclaw that referenced this pull request Jun 3, 2026
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant