fix: honor explicit message tool allowlists#82889
Merged
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: honor explicit message tool allowlists This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
be0c245 to
a673a85
Compare
galiniliev
pushed a commit
to galiniliev/openclaw
that referenced
this pull request
May 20, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
galiniliev
pushed a commit
to galiniliev/openclaw
that referenced
this pull request
May 25, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
SYU8384
pushed a commit
to SYU8384/openclaw
that referenced
this pull request
Jun 3, 2026
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messageallow/alsoAllow policy during embedded core tool construction, with deny precedence preserved.messageallowlists through restrictive profiles, including literal, grouped, and wildcard allowlists.messagetool not exposed to weixin agent despite being inalsoAllowsince 2026.5.16-beta.3 #82833.Verification
pnpm exec oxfmt --check src/agents/pi-tools.ts src/agents/pi-tools.create-openclaw-coding-tools.test.ts src/agents/openclaw-tools.ts src/agents/openclaw-tools.update-plan.test.ts src/plugins/runtime/types-channel.ts && git diff --checkpnpm test src/agents/openclaw-tools.update-plan.test.ts src/agents/pi-tools.create-openclaw-coding-tools.test.tspnpm test src/plugins/contracts/plugin-sdk-index.test.ts src/plugins/contracts/plugin-sdk-runtime-api-guardrails.test.tspnpm changed:lanes --jsonpnpm check:changedvia Blacksmith Testboxtbx_01krt1xb26bzqpw3xgs3p5sw5f, GitHub Actions https://github.com/openclaw/openclaw/actions/runs/25980959972Real behavior proof
Behavior addressed: embedded channel runs can now keep the
messagetool when it is explicitly allowed bytools.alsoAllowor runtime tool allowlists, even under restrictive profiles such asminimal.Real environment tested: local repo checkout plus delegated Blacksmith Testbox changed-check.
Exact steps or command run after this patch:
pnpm test src/agents/openclaw-tools.update-plan.test.ts src/agents/pi-tools.create-openclaw-coding-tools.test.ts;pnpm check:changed.Evidence after fix: focused tests cover embedded factory inclusion, config
tools.alsoAllow, deny precedence, runtime literal/group/wildcard allowlists, and restrictive profile filtering.Observed result after fix: focused tests passed; plugin SDK contract tests passed; Testbox
check:changedpassed with exit 0.What was not tested: live Weixin send was not run because this checkout does not have a configured Weixin bot session; external
@tencent-weixin/openclaw-weixinstill needs to move off deprecated low-level runtime helpers for the full channel-side update.