Recover stale embedded tool calls during gateway diagnostics#82369
Merged
Conversation
fa74ada to
e9b46e2
Compare
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: Recover stale embedded tool calls during gateway diagnostics This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
…w#82369) * fix(gateway): recover stale embedded tool calls * chore(changelog): note stale embedded tool recovery
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
…w#82369) * fix(gateway): recover stale embedded tool calls * chore(changelog): note stale embedded tool recovery
SYU8384
pushed a commit
to SYU8384/openclaw
that referenced
this pull request
Jun 3, 2026
…w#82369) * fix(gateway): recover stale embedded tool calls * chore(changelog): note stale embedded tool recovery
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
…w#82369) * fix(gateway): recover stale embedded tool calls * chore(changelog): note stale embedded tool recovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Behavior addressed: stale native tool calls inside active embedded runs can now be recovered by diagnostic abort once the tool/progress age exceeds the stuck-session abort threshold; gateway restart also caps active embedded-run drain before aborting those runs without shortening unrelated active-task drain.
Real environment tested: local live OpenClaw gateway with Codex live harness and real provider auth; direct live provider CLI probe also passed.
Exact steps or command run after this patch: node scripts/run-vitest.mjs src/logging/diagnostic-session-attention.test.ts src/logging/diagnostic.test.ts src/logging/diagnostic-stuck-session-recovery.runtime.test.ts src/cli/gateway-cli/run-loop.test.ts; codex review --uncommitted; git diff --check; OPENCLAW_LIVE_CODEX_HARNESS=1 OPENCLAW_LIVE_TEST_QUIET=0 node scripts/test-live.mjs -- src/logging/issue81976.tmp.live.test.ts
Evidence after fix: focused Vitest suite passed; Codex review found no actionable correctness issues after fixes; live gateway/provider synthetic recovery probe passed.
Observed result after fix: diagnostic recovery aborts the stale embedded run, and restart drain aborts active embedded runs after the configured grace while preserving normal active-task wait behavior.
What was not tested: full Telegram/provider E2E was not run. Broad changed check is blocked by an unrelated existing type failure in src/cron/isolated-agent.model-formatting.test.ts.
Fixes #81976