fix(codex): fail fast after quiescent turn completion stalls#82172
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. by source inspection: the current-main branch disarms the short completion watchdog after the reduced final Real behavior proof Next step before merge Security Review detailsBest possible solution: Land this after maintainer review and redacted real-run proof, keeping the change scoped to Codex app-server watchdog semantics and its regression coverage. Do we have a high-confidence way to reproduce the issue? Yes by source inspection: the current-main branch disarms the short completion watchdog after the reduced final Is this the best way to solve the issue? Yes for the code direction: re-arming the existing short watchdog at the final non-assistant current-turn completion is the narrowest fix for the identified gap. Merge should still wait for real behavior proof from the contributor's setup. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 1b87ba8ca57b. |
|
Maintainer proof for landing #82172. Behavior addressed: Codex app-server can go quiet after the last non-assistant current-turn Before proof on current main:
After-fix proof on PR logic:
Real environment tested:
CI/proof gaps:
Thanks @funmerlin. Re-review progress:
|
b352ae6 to
d73b187
Compare
|
Landed in 127156a from source head d73b187. Verification before merge:
Thanks @funmerlin. |
Summary
turn/completedRefs #82171.
Verification
pnpm test extensions/codex/src/app-server/run-attempt.test.ts -t 'keeps the post-tool completion watchdog armed across dynamic tool completion bookkeeping|times out promptly when the last completed non-assistant current-turn item is not followed by turn completion|does not release the session after only a raw assistant response item|releases the session when a completed agent message item goes quiet'pnpm build