fix(auth): accept oauthRef profiles for runtime auth#81633
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. source-level. On current main, construct an OpenAI Codex OAuth credential with missing or blank Real behavior proof Next step before merge Security Review detailsBest possible solution: Land the focused eligibility fix after maintainer review and after the contributor adds redacted real Codex runtime proof that an Do we have a high-confidence way to reproduce the issue? Yes, source-level. On current main, construct an OpenAI Codex OAuth credential with missing or blank Is this the best way to solve the issue? Yes, the proposed direction is narrow and matches the existing SecretRef-style eligibility contract by treating a valid Codex What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against fe89243c3b24. |
|
Superseded by #81638. |
c6e1276 to
3f65c35
Compare
|
Landed via rebase onto main.
|
Summary
Fix Codex runtime auth selection for OAuth profiles stored with
oauthRefinstead of inline tokens.OpenClaw already persists OpenAI Codex OAuth secrets behind
oauthRef, andmodels statuscan show those profiles as OK. Runtime auth ordering still treated OAuth as configured only whenaccessorrefreshwas inline, so the Codex app-server bridge could start without a selected profile and hit Responses withprofile=-/ missing auth.Real behavior proof
openai-codexOAuth profile backed only byoauthRefwas reported as OK by status, butresolveAuthProfileOrdertreated it asmissing_credential, so Codex app-server auth selection found no profile.evaluateStoredCredentialEligibilityacceptsoauthRef,resolveAuthProfileOrderincludes the profile, and Codex app-server auth selection picks it for login.Verification
pnpm test:changedpnpm check:changed