[codex] fix plugins doctor runtime config warning attribution#81425
[codex] fix plugins doctor runtime config warning attribution#81425BKF-Gitty wants to merge 1 commit into
Conversation
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: [codex] fix plugins doctor runtime config warning attribution This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
a94c851 to
d8df19d
Compare
d8df19d to
2297dc5
Compare
…BKF-Gitty) Co-authored-by: BKF-Gitty <bandark@mac.com>
|
Landed on main in 4d8aec8. I could not update this PR branch directly because maintainer edits are disabled ( Verification:
Source PR head: 2297dc5 Thanks @BKF-Gitty. For future PRs, enabling "Allow edits by maintainers" lets us preserve the PR branch and merge directly after fixups. |
…BKF-Gitty) Co-authored-by: BKF-Gitty <bandark@mac.com>
…(thanks @BKF-Gitty) Co-authored-by: BKF-Gitty <bandark@mac.com>
…(thanks @BKF-Gitty) Co-authored-by: BKF-Gitty <bandark@mac.com>
…(thanks @BKF-Gitty) Co-authored-by: BKF-Gitty <bandark@mac.com>
…(thanks @BKF-Gitty) Co-authored-by: BKF-Gitty <bandark@mac.com>
…(thanks @BKF-Gitty) Co-authored-by: BKF-Gitty <bandark@mac.com>
Summary
Describe the problem and fix in 2–5 bullets:
openclaw plugins doctorcould load a plugin that calls deprecatedapi.runtime.config.loadConfig()/writeConfigFile(...), print an anonymousruntime-config-load-writewarning, then still report no plugin issues.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Real behavior proof (required for external PRs)
External contributors must show after-fix evidence from a real OpenClaw setup. Unit tests, mocks, lint, typechecks, snapshots, and CI are supplemental only. Screenshots are encouraged even for CLI, console, text, or log changes; terminal screenshots and copied live output count. Be mindful of private information like IP addresses, API keys, phone numbers, non-public endpoints, or other private details when providing evidence.
git diff --checkpnpm test src/plugins/runtime/runtime-config.test.ts src/plugins/registry.runtime-config.test.tspnpm test src/cli/plugins-cli.list.test.tspnpm tsgoplugin "legacy-plugin" runtime config.loadConfig()andplugin "legacy-plugin" runtime config.writeConfigFile()plus registry-scope assertions.openclaw plugins doctorend-to-end.plugin runtime config.loadConfig() is deprecated (runtime-config-load-write); use config.current().followed byNo plugin issues detected.Root Cause (if applicable)
For bug fixes or regressions, explain why this happened, not just what changed. Otherwise write
N/A. If the cause is unclear, writeUnknown.Regression Test Plan (if applicable)
For bug fixes or regressions, name the smallest reliable test coverage that should catch this. Otherwise write
N/A.src/plugins/runtime/runtime-config.test.ts,src/plugins/registry.runtime-config.test.ts,src/cli/plugins-cli.list.test.tsloadConfigandwriteConfigFilewarnings include plugin id/source when called under plugin scope, and per-plugin runtime config helpers receive the owning plugin scope from the registry proxy.src/cli/plugins-cli.list.test.tsstill covers the clean doctor success path.User-visible / Behavior Changes
Deprecated plugin runtime config warnings now include plugin identity and source path when emitted from plugin-scoped runtime helpers.
Diagram (if applicable)
Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation: N/ARepro + Verification
Environment
openclaw-shellSteps
tsgo.Expected
Actual
pnpm test src/plugins/runtime/runtime-config.test.ts src/plugins/registry.runtime-config.test.ts: 2 files passed, 7 tests passed.pnpm test src/cli/plugins-cli.list.test.ts: 1 file passed, 9 tests passed.pnpm tsgo: passed.Evidence
Attach at least one:
Regression tests now assert warning strings like:
Human Verification (required)
What you personally verified (not just CI), and how:
pluginSourcewhen only a new plugin id is supplied.openclaw plugins doctor.Review Conversations
If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.
Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoRisks and Mitigations
withPluginRuntimePluginScopepreserves the existing scope via object spread and only updatespluginId/pluginSource.